Button and ButtonGroup Component in all variants #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitLab Pipeline ActionGeneral informationLink to pipeline: https://gitlab.com/code0-tech/base-ui/-/pipelines/1109323481 Status: Passed Job summariesstorybook:buildStorybook available at https://code0-tech.gitlab.io/-/base-ui/-/jobs/5767052666/artifacts/storybook-static/index.html |
Taucher2003
approved these changes
Dec 16, 2023
There was a problem hiding this comment.
Codewise looks good, but one note on behaviour:
I would expect some indication when the button is clicked. Like border changing a the color a bit.
Really good would be a ripple effect, but I don't know how difficult that is. (Like what you can see at the examples here: https://vuetifyjs.com/en/components/buttons/#usage)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #8