Update img_avg.py/ There were typos #41
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Lintly has detected code quality issues in this pull request.
phrdang
requested review from
a team and
phrdang
and removed request for
a team
phrdang
left a comment
phrdang
left a comment
There was a problem hiding this comment.
My overall comments:
- This is a really cool problem! The main issue I see right now is the complexity - students need to understand exactly what the problem is asking and when I was reading the instructions I didn't know how to begin approaching it
- Also, this problem requires some basic knowledge of the libraries used, and I think we either need to teach students that in the main curriculum, provide a link to an article or something that they could use, or simplify this problem so that it's doable
Also please see my comment about the solution1 function.
|
|
||
|
|
||
| # write code to create newimg here | ||
| def solution1(): |
There was a problem hiding this comment.
@Citrus716 could you change this to not be a function since the students haven't learned them yet?
| @@ -1,12 +1,12 @@ | |||
| """ | |||
| """ | |||
| Alternating | |||
There was a problem hiding this comment.
@code-for-tomorrow/python who submitted this practice problem? I'm wondering because I noticed there's no solution for it...
Yes, I didn't make the img_avg, but I see can see trouble understanding the problem. What the problem is asking for is not too hard imo as the complexities dealing with the libraries are already implemented for the student. I also added an example 3D array with other minor changes if that helps anyone. (Answer to second part)I think maybe describing what the code does, but not expecting them to actually write the code dealing with the libraries. Also, thanks to who wrote this problem. |
Fixing Typos
img_avg
Repeat the Problem Title, Chapter #, and Section Name format for as many problems as you have.
Optional: Brief description of changes or any other notes you want to leave to the Curriculum Development team