Skip to content

MLH Code of Conduct button visible on mobile, content vertical centering on desktop #938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Sep 5, 2020
Merged

MLH Code of Conduct button visible on mobile, content vertical centering on desktop #938

merged 11 commits into from
Sep 5, 2020

Conversation

@ww3637
Copy link
Member

@ww3637 ww3637 commented Jul 25, 2020

No description provided.

@ww3637 ww3637 linked an issue Jul 25, 2020 that may be closed by this pull request
Add "MLH Code of Conduct" to mobile site #936
Closed
@ww3637 ww3637 changed the title MLH Code of Conduct nav button now shows on mobile MLH Code of Conduct shows on mobile, desktop vertical centering Jul 25, 2020
@ww3637 ww3637 changed the title MLH Code of Conduct shows on mobile, desktop vertical centering MLH Code of Conduct shows on mobile, content vertical centering on desktop Jul 25, 2020
@ww3637 ww3637 requested review from peterkos and sjv01180 July 25, 2020 07:57
@ww3637 ww3637 linked an issue Jul 25, 2020 that may be closed by this pull request
Hero text + image is not vertically centered #931
Closed
@ww3637 ww3637 added the BH7 label Aug 1, 2020
@peterkos
Copy link
Contributor

peterkos commented Aug 7, 2020

I'd suggest having the centering be less logical and more optical:
Thoughts? I'll ping design too tomorrow

Before After
Screen Shot 2020-08-06 at 11 00 18 PM Screen Shot 2020-08-06 at 11 00 14 PM

peterkos
peterkos reviewed Aug 7, 2020
View reviewed changes
@ww3637
Copy link
Member Author

ww3637 commented Aug 7, 2020

I'd suggest having the centering be less logical and more optical:
Thoughts? I'll ping design too tomorrow

I definitely prefer your before over the after. I'll see if I can mess w/ the hero image scaling to shift it back a little. Think it looks fine on my machine

Before After

@ww3637 ww3637 self-assigned this Aug 16, 2020
@ww3637 ww3637 changed the title MLH Code of Conduct shows on mobile, content vertical centering on desktop MLH Code of Conduct button visible on mobile, content vertical centering on desktop Aug 16, 2020
@peterkos peterkos mentioned this pull request Aug 18, 2020
Merged
@peterkos
Copy link
Contributor

peterkos commented Aug 18, 2020

Feedback was to maybe try an in-between of the two examples

@peterkos peterkos added this to the BrickHack7 milestone Aug 18, 2020
@ww3637
Copy link
Member Author

ww3637 commented Aug 18, 2020

I'm aware, I'll try to make changes according to the feedback soon

@ww3637
Copy link
Member Author

ww3637 commented Aug 22, 2020

Don't ask what happened here

@ww3637 ww3637 requested a review from peterkos August 22, 2020 23:33
peterkos
peterkos previously approved these changes Aug 24, 2020
View reviewed changes
Copy link
Contributor

@peterkos peterkos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work on centering 😄
Next PR we can address refactoring the code, including standardizing the whitespace. But for now these changes are good!

@ww3637 ww3637 requested a review from peterkos August 24, 2020 23:53
peterkos
peterkos previously requested changes Aug 25, 2020
View reviewed changes
@peterkos peterkos removed the request for review from sjv01180 August 30, 2020 00:51
@peterkos
Copy link
Contributor

peterkos commented Aug 30, 2020

image
Screen Shot 2020-08-29 at 9 12 57 PM

@ww3637 ww3637 mentioned this pull request Sep 5, 2020
Closed
@ww3637 ww3637 requested a review from peterkos September 5, 2020 03:03
@ww3637 ww3637 dismissed peterkos’s stale review September 5, 2020 03:06

Changes will be addressed in new issue

peterkos
peterkos approved these changes Sep 5, 2020
View reviewed changes
@ww3637 ww3637 merged commit 1fa70e5 into develop Sep 5, 2020
@ww3637 ww3637 deleted the centering branch September 6, 2020 14:49
peterkos pushed a commit that referenced this pull request Aug 4, 2021
@ww3637
Merge pull request #938 from codeRIT/centering
02fc8ab 
MLH Code of Conduct button visible on mobile, content vertical centering on desktop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peterkos peterkos peterkos approved these changes

Assignees

@ww3637 ww3637

Labels

BH7

Projects

None yet

Milestone

BrickHack7 Registration Open

Development

Successfully merging this pull request may close these issues.

Add "MLH Code of Conduct" to mobile site Hero text + image is not vertically centered

3 participants

@ww3637 @peterkos