feat: rename magic link button and page title to 'Sign in with e-mail' - #56
Merged
Merged
Conversation
mroderick
changed the title
mroderick
force-pushed
the
feat/rename-send-magic-link-button
branch
from
August 6, 2026 09:39
18aee25 to
9eec6be
Compare
mroderick
marked this pull request as ready for review
August 6, 2026 09:48
till
previously approved these changes
Aug 6, 2026
mroderick
force-pushed
the
feat/rename-send-magic-link-button
branch
from
August 6, 2026 13:05
9eec6be to
521f201
Compare
mroderick
force-pushed
the
feat/rename-send-magic-link-button
branch
from
August 6, 2026 13:11
521f201 to
7d5f9c4
Compare
mroderick
enabled auto-merge
August 6, 2026 13:15
Collaborator
Author
|
I resolved a conflict. Can I have another ✅ @till ? |
till
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The login form button read "Send magic link", but "magic link" is jargon — not everyone knows the term. "E-mail" is universally understood.
Change
Rename the button text to "Sign in with e-mail" in both places it appears:
MagicLinkButtoncomponent on the sign-in page (src/app/components/login.js)src/app/routes/auth.js)The route paths, page heading, and functionality are unchanged — only the visible label.
Tests
Extended the magic-link page render test to assert the new button text appears. All 12 feature assertions pass; Prettier and ESLint clean.
Also changed
Reworded the magic-link page
<title>from "Magic Link Login" to "Sign in with e-mail" to keep all user-facing copy free of magic-link jargon. (The h1 heading was already "Sign In".)Also reworded the expired-link error message to "The sign-in link has expired or already been used" (
src/app/routes/auth.js).