fix: address presenter spec flake from Faker apostrophe in flat#2696
Merged
Conversation
The "escapes HTML in address elements" test hardcoded flat, city, and postal_code raw in the expected value, but the presenter escapes all fields through ERB::Util.html_escape. When Faker generates a street name containing an apostrophe (e.g. O'Kon Land), html_escape converts it to ' causing a mismatch. Now uses html_escape for all components in the expected value, consistent with the first test in the same describe block.
KimberleyCook
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
"escapes HTML in address elements" test in
AddressPresenterflakes on CI when Faker generates a street name with an apostrophe (e.g. "O'Kon Land", "D'Amore Mill").The expected value used
address.flat,address.city, andaddress.postal_coderaw (unescaped), but the presenter appliesERB::Util.html_escapeto all fields. An apostrophe gets escaped to', causing a mismatch.Change
Use
html_escapefor all components in the expected value of the XSS test, consistent with the first test in the samedescribeblock. Only the expected-value construction changed — test intent is unchanged.Verification
bundle exec rspec spec/presenters/address_presenter_spec.rb --seed 44342passes