fix: move EventHelper from app/helpers to app/models/concerns#2702
Open
mroderick wants to merge 1 commit into
Open
fix: move EventHelper from app/helpers to app/models/concerns#2702mroderick wants to merge 1 commit into
mroderick wants to merge 1 commit into
Conversation
EventHelper contains model validation logic (venue_or_remote_must_be_present, sponsors_uniqueness, etc.) operating on model state, making it a concern rather than a view helper. Moving it to app/models/concerns/ fixes a presentation-to-domain layer violation. The include EventHelper line in Event does not change — Rails autoloading resolves the module from app/models/concerns/ under the same name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
EventHelperlived inapp/helpers/(Presentation layer per Rails conventions) but is included in theEventmodel (Domain layer). It defines model validation methods (sponsors_uniqueness,venue_or_remote_must_be_present, etc.) operating on model state — a presentation-to-domain layer violation.Solution
Move
EventHelperfromapp/helpers/event_helper.rbtoapp/models/concerns/event_helper.rb. Theinclude EventHelperinapp/models/event.rbis unchanged — Rails autoloading resolves the module fromapp/models/concerns/under the same name.Verification