test: Stabilise TomSelect helper against focus races - #2741
Merged
Conversation
Fix a flaky failure where Capybara clicks did not reliably focus the TomSelect input in headless CI, so the search AJAX was never triggered and the dropdown options never appeared. Changes: - Scope selectors to the specific TomSelect via `from`. - Add an explicit JavaScript focus call after clicking. - Require `from:` in both helpers for explicit scoping.
mroderick
marked this pull request as ready for review
July 28, 2026 06:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a flaky failure in
select_from_tom_selectwhere Capybara clicks did not reliably focus the TomSelect input in headless CI, so the search AJAX was never triggered and the dropdown options never appeared.The helper now:
fromelement IDfrom:in both helpers so the scoping is always explicitRelated: #2740
Validation:
bundle exec rspec spec/features/admin/— 110 examples, 0 failuresbundle exec rubocop spec/support/select_from_tom_select.rb spec/features/admin/meeting_spec.rb— no offenses