Fix N+1 query on dashboard (workshop host) - #2782
Merged
Merged
Conversation
Add workshop_host to eager_load in DashboardQuery.upcoming_events. Resolves the eager-loading detection bullet for GET /.
mroderick
force-pushed
the
feature/fix-dashboard-eager-loading
branch
from
August 5, 2026 10:35
ff0cd4a to
b4be22b
Compare
mroderick
marked this pull request as ready for review
August 5, 2026 10:36
KimberleyCook
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
:workshop_hostto theeager_loadinDashboardQuery.upcoming_events, resolving the eager-loading detection bullet logged forGET /.Why
DashboardQuery.upcoming_events(app/queries/dashboard_query.rb) loadedworkshop_hostlazily on each workshop when rendering the front page, triggering an N+1 detected by Rails' eager-loading checker.The query already uses
eager_loadfor:chapter, :sponsors, :organisers, :permissions, so:workshop_hostjoins the same preload.Verification
bundle exec rspec spec/queries/dashboard_query_spec.rb— 9 examples, 0 failures.