CSS transition add #337
Merged
CSS transition add #337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardwestenra
previously requested changes
Feb 8, 2017
html/lesson5/tutorial.md
Outdated
| } | ||
| ``` | ||
|
|
||
| Add the **property** which we are chaning and its new value: |
There was a problem hiding this comment.
By chaning do you mean changing or chaining?
html/lesson5/tutorial.md
Outdated
|
|
||
| ### Transitions | ||
|
|
||
| Let's take some **property** in our code and change it, making it somehow different. E.g. The `background` of the two links named **btn**, and let's change it on hover. This is a 'change'. Now we can have this affect take place during a number of seconds, this is a **Transition**. |
There was a problem hiding this comment.
I feel like the wording in this paragraph could be improved, but it's not essential. How about something like this though?
Let's modify a **property** in our code - e.g. the button link `background` colour - so that it changes when you hover over the button. By default, the change will happen instantaneously. However we can animate the effect so that it changes slowly over time, using the **transition** property.
|
|
||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Do we need all these line breaks?
richardwestenra
dismissed
their stale review
oops I reviewed an old commit by mistake, sorry! I've no idea how this happened because I actively tried to avoid this.
|
@richardwestenra all of your comments are not on my updates, those are marias that I merged into another branch and amended. |
|
@richardwestenra just saw your new comment 😂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added in Maria's CSS transition addition from 24 PR and got distracted and made some little wording amendments.