local storage device linking 3g7ves - #404
Open
promisszn wants to merge 3 commits into
Open
Conversation
Replaces lib/storage.ts's fakeUrl() string template with a real, fs-backed ObjectStore implementation used outside production, served through a new /local-storage Express route so presigned PUT/GET URLs issued in dev are genuine, working URLs instead of never-dereferenced strings. getObjectStore() now selects the local-disk store outside production and the real S3 client in production, so fileCleanup.ts's hard-delete pass works unchanged against whichever backend is active. No Docker/MinIO needed locally.
.claude/worktrees/ holds isolated working copies the Agent tool spins up for background subagents (used here to parallelize work on issues codebestia#333/codebestia#334/codebestia#337) — internal tooling state, not project source.
|
@promisszn Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
promisszn
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LocalDiskObjectStore(apps/backend/src/lib/localObjectStore.ts), a pure-fsimplementation matchingObjectStore's shape (putObject/getObject/deleteObject/getPresignedPutUrl/getPresignedGetUrl), storing bytes under a gitignoredapps/backend/.local-storage/directory./local-storageExpress route (apps/backend/src/routes/localStorage.ts, mounted only outside production) that serves real GET/PUT against those files, gated by an HMAC-signed, expiring, method-bound token — the same guarantee a real presigned S3 URL provides.getObjectStore()(lib/objectStore.ts) now selects the local-disk store outside production and the real S3 client in production, soservices/fileCleanup.ts's hard-delete pass keeps working unchanged against whichever backend is active.lib/storage.tsno longer falls back tofakeUrl()— itsisProduction()branch now issues a real presigned URL from the local-disk store in dev/test and from S3 in production.Test plan
pnpm --filter backend test— 413/413 passing, including newlocalObjectStore.test.tsandlocalStorage.routes.test.ts(round-trip PUT→GET, expired/tampered/wrong-method signature rejection, path-traversal rejection) and new coverage inobjectStore.test.tsfor the prod/dev backend selection.pnpm --filter backend lintandtsc --noEmit— no new errors (pre-existing, unrelated errors inroomManager.ts/stellarListener.ts/uploads.test.tsconfirmed present onmainbefore this change).Closes #330