Refresh marketing site for Swiftpkgr 0.3.0 - #6
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe README and homepage now describe the upcoming Swiftpkgr desktop app, while the site stylesheet is replaced with a light visual system. Homepage metadata, navigation, app-preview content, responsive breakpoints, focus styling, and reduced-motion behavior were also updated. ChangesSwiftpkgr site refresh
Estimated code review effort: 4 (Complex) | ~45 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@site/index.html`:
- Around line 111-130: Update the app preview markup around the “Build Package”
control so the visual mock is exposed as one labeled image and the nonfunctional
control is no longer keyboard-focusable; replace the fake button with a styled
span using the preview-button class, and update the corresponding .build-row
button stylesheet selector to .build-row .preview-button.
In `@site/styles.css`:
- Around line 505-509: Update the responsive styles for .app-window and the
corresponding sections at the additional affected breakpoints to collapse or
hide the decorative 108px sidebar at 320px, preserving enough width for the
non-wrapping build row and its button to remain visible despite overflow:
hidden.
- Around line 10-11: Update the primary navigation and button control styles
using --orange so their backgrounds use --orange-dark, or change their text
color to one that meets normal-text contrast requirements. Apply the same
contrast-safe treatment to the additional control styles referenced by the
comment, while preserving existing control behavior and layout.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: aade7302-5bac-4a5d-be02-95eaa2335d28
⛔ Files ignored due to path filters (1)
site/assets/og.pngis excluded by!**/*.png
📒 Files selected for processing (3)
README.mdsite/index.htmlsite/styles.css
Comment on lines
+111
to
+130
| <div class="app-window glow-panel" aria-label="Swiftpkgr desktop app preview"> | ||
| <div class="app-titlebar"> | ||
| <span></span><span></span><span></span> | ||
| <b>Swiftpkgr</b> | ||
| </div> | ||
| <div class="app-content"> | ||
| <aside> | ||
| <small>PROJECT</small> | ||
| <b>MyApp</b> | ||
| <a class="active">Package</a> | ||
| <a>Distribution</a> | ||
| <a>Signing</a> | ||
| <a>Notarization</a> | ||
| </aside> | ||
| <div class="app-editor"> | ||
| <small>PACKAGE SETTINGS</small> | ||
| <label>Name <span>MyApp-${version}</span></label> | ||
| <label>Identifier <span>com.example.myapp</span></label> | ||
| <label>Version <span>2.3</span></label> | ||
| <div class="build-row"><i></i><p><b>Ready to build</b><small>Project settings are valid</small></p><button>Build Package</button></div> |
Contributor
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Remove the nonfunctional button from the accessibility tree.
Line 130 creates a keyboard-focusable “Build Package” button with no action inside a visual mock. Expose the preview as one labeled image and render the fake button as a styled span.
Proposed fix
- <div class="app-window glow-panel" aria-label="Swiftpkgr desktop app preview">
+ <div class="app-window glow-panel" role="img" aria-label="Swiftpkgr desktop app preview">
...
- <div class="build-row"><i></i><p><b>Ready to build</b><small>Project settings are valid</small></p><button>Build Package</button></div>
+ <div class="build-row"><i></i><p><b>Ready to build</b><small>Project settings are valid</small></p><span class="preview-button">Build Package</span></div>Update .build-row button to .build-row .preview-button in the stylesheet.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@site/index.html` around lines 111 - 130, Update the app preview markup around
the “Build Package” control so the visual mock is exposed as one labeled image
and the nonfunctional control is no longer keyboard-focusable; replace the fake
button with a styled span using the preview-button class, and update the
corresponding .build-row button stylesheet selector to .build-row
.preview-button.
Comment on lines
+10
to
+11
| --orange: #ed5b23; | ||
| --orange-dark: #c94313; |
Contributor
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Increase contrast for primary controls.
White text on --orange is approximately 3.4:1, so the small navigation and button labels fail normal-text contrast. Use --orange-dark for these backgrounds or switch to sufficiently dark text.
Possible fix
.nav-github {
- background: var(--orange);
+ background: var(--orange-dark);
color: `#fff`;
- border: 1px solid var(--orange);
+ border: 1px solid var(--orange-dark);
}
.button-primary {
- background: var(--orange);
- border-color: var(--orange);
+ background: var(--orange-dark);
+ border-color: var(--orange-dark);
color: `#fff`;
}Also applies to: 106-119, 214-223
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@site/styles.css` around lines 10 - 11, Update the primary navigation and
button control styles using --orange so their backgrounds use --orange-dark, or
change their text color to one that meets normal-text contrast requirements.
Apply the same contrast-safe treatment to the additional control styles
referenced by the comment, while preserving existing control behavior and
layout.
Comment on lines
+505
to
+509
| .app-window { | ||
| min-height: 420px; | ||
| overflow: hidden; | ||
| border-radius: 4px; | ||
| } |
Contributor
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Prevent the app preview from clipping at 320px.
The 108px sidebar leaves too little room for the non-wrapping build row, and overflow: hidden clips its button. Collapse the decorative sidebar at this breakpoint.
Proposed fix
`@media` (max-width: 480px) {
- .app-content { grid-template-columns: 108px 1fr; }
+ .app-content { grid-template-columns: 1fr; }
+ .app-content aside { display: none; }
.app-editor { padding: 24px 14px; }
}Also applies to: 537-541, 831-841
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@site/styles.css` around lines 505 - 509, Update the responsive styles for
.app-window and the corresponding sections at the additional affected
breakpoints to collapse or hide the decorative 108px sidebar at 320px,
preserving enough width for the non-wrapping build row and its button to remain
visible despite overflow: hidden.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
git diff --checkREADME.mdandsite/Summary by CodeRabbit
New Features
Documentation
Style