You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Well, it seems like that hashes are created due to scoped styles (perfectly valid) and @reference (e.g.: @reference "../../../index.css";) is somehow breaking this because the paths somehow mismatch (i.e.: they don't use the @ alias as starting point).
I personally find those tests a bit fragile since the snapshots need to recomputed anything changes, but so be it. :)
Maybe the tests would be more stable/robust if a snapshot serialized would be added to drop the data-v-XYZ properties while doing the matching, but I can't of course decide this on my own.
Since I've no clue how to fix this in an absolutely safe way, I'll close this PR.
@SteKoe the main issue with the tests discovery on Windows is that in the includes an absolute path is provided.
Maybe you've an idea on how to adapt the config so that relative ones can be used instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the error reported in #5241 (comment)
Please be aware that some tests fail on Windows due to mismatches like
(I've no clue what's that about)and others fail due to localization issues