fix(#5251): expose the colors configured in the settings directly rather then calling a method which is not allowed from Thymeleaf 3.1.4

[cdprete]

Takeover of #5264.
Fixes #5251.
Tested locally with the servlet & reactive samples with the profiles dev,insecure,themed active (themed config copied from the servlet example into the reactive for this reason).

@SteKoe some of the tests actually fail on Windows, but they do fail also with the master branch, so I assume it's safe.

[SteKoe]

Looks good except that CssColorUtils can be a static Utility class and do not need to be injected (just like PathUtils). I have pushed a change for that.

[cdprete]

Looks good except that CssColorUtils can be a static Utility class and do not need to be injected (just like PathUtils). I have pushed a change for that.

I realized that, but I didn't want to change it without knowing why you guys made it as a bean in the first place.
For example, to mock it easily with @MockitoBean or so.

By the way, the build is broken now with your change 😅
Can you please fix it?

[cdprete]

@SteKoe what do you think about the idea of adding some tests to verify that the colors are properly populated both for the controller method and the CSS file?

I know the current implementation is quite trivial and it's maybe even an overkill to test it, but having them could potentially avoid bugs in the future due to refactoring.

For example: pass twice the same grade value in the controller for different colors or use a non matching name in the CSS file.

[cdprete]

@SteKoe I was about to add the tests but you've been faster 🙂

[SteKoe]

@SteKoe I was about to add the tests but you've been faster 🙂

sorry! :D

[cdprete]

@SteKoe I was about to add the tests but you've been faster 🙂

sorry! :D

No worries 👍

Your implementation is actually better than the one I was thinking about ;)