Update playwright.md #2255
Merged
Update playwright.md #2255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Edits update to new generator version, minor typos, clarifications. Otherwise good overview docs!
tomByrer
commented
Mar 7, 2020
| ## Writing Tests | ||
|
|
||
| CodeceptJS test should be created with `gt` command: | ||
| Additional CodeceptJS tests should be created with `gt` command: |
Contributor
Author
There was a problem hiding this comment.
There is 1 test created by the generator, which seems to be the suggested setup flow.
DavertMik
approved these changes
Mar 10, 2020
Contributor
DavertMik
left a comment
DavertMik
left a comment
There was a problem hiding this comment.
Thank you, looks good!
kobenguyent
approved these changes
Mar 10, 2020
DavertMik
added a commit
that referenced
this pull request
Mar 27, 2020
* Updated to click the firstVisibleElement (#2230) Earlier it seems like it was clicking the first element. Now it clicks the first visible element, * add missing JSDoc parameter for seeInPopup method, update documentation (#2228) * add missing JSDoc parameter for seeInPopup method, update documentation * refactor duplicated JSDoc of seeInSource method to mustache file * update interactive shell in basics.md (#2256) I guess docs had older version? * Update playwright.md (#2255) Edits update to new generator version, minor typos, clarifications. Otherwise good overview docs! * Readme update and fix import (#2267) * remove let, add const * fix import error * Small fixes, fix inheritance * fix eslint * alignment * fix comments Co-authored-by: SS <syam.s@outlook.com> Co-authored-by: Hanna Becker <hanna.e.becker@gmail.com> Co-authored-by: Tom Byrer <tomByrer@gmail.com> Co-authored-by: João Paulo Vanzuita <joao.vanzuita@cobi.bike> Co-authored-by: Michael Bodnarchuk <DavertMik@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edits update to new generator version, minor typos, clarifications.
Otherwise good overview docs!
Type of change