Small fixes, fix inheritance #2269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlier it seems like it was clicking the first element. Now it clicks the first visible element,
…on (codeceptjs#2228) * add missing JSDoc parameter for seeInPopup method, update documentation * refactor duplicated JSDoc of seeInSource method to mustache file
I guess docs had older version?
Edits update to new generator version, minor typos, clarifications. Otherwise good overview docs!
Contributor
Author
|
@DavertMik Hey, should i remove this PR? |
potapovDim
force-pushed
the
small_fixes
branch
3 times, most recently
from
c8b13db to
ce0c950
Compare
* remove let, add const * fix import error
Vorobeyko
suggested changes
Mar 19, 2020
Contributor
|
Clones added
============
- lib/helper/WebDriverIO.js 1
- lib/helper/WebDriver.js 3
Clones removed
==============
+ lib/command/run.js -1
+ test/helper/Playwright_test.js -1
+ test/runner/dry_run_test.js -1
+ test/helper/Puppeteer_test.js -1
See the complete overview on Codacy |
DavertMik
approved these changes
Mar 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/Description of the PR
Type of change
Checklist:
npm run lint)npm test)