-
Notifications
You must be signed in to change notification settings - Fork 92
Add configuration class, ability to specify a branch to run coverage on, and ability to silence warnings #18
Add configuration class, ability to specify a branch to run coverage on, and ability to silence warnings #18
Conversation
* Allow configuration of a branch to run coverage on (all is default)
* Allow disable of warnings ("Not reporting to Code Climate...")
|
Thanks. I think this is useful functionality. For the branch, we actually have to use a bit of logic in order to work out the "effective branch" (since the CI system and Git may have different information about the branch name). This is in the So I think the branch filtering should use the result from For the |
|
@brynary sorry for the delay getting back to you on this. I totally missed Formatter#compute_branch, that makes perfect sense... as does the log level idea. I'll see what I can do on that. |
|
@brynary added changes you suggested, including breaking out git operations to a separate class. Let me know if that's what you had in mind. |
|
Thanks, Chris. This looks really good. Can you please update the README with examples of configuring the logger and the branch, and I'll merge. I noticed the |
|
README updated. Good catch on the unneeded attr_accessor... I forgot to remove that. |
…warnings Add configuration class, ability to specify a branch to run coverage on, and ability to silence warnings
|
Merged. Thanks! |
|
Thanks, Bryan. Glad I could help out! |
|
Anyone having luck silencing warnings? I'm still getting them in dev/test modes. |
|
Ok, |
|
@dogweather what does your config block look like? |
Since Code Climate only runs analysis on one branch, it seemed reasonable to be able to specify a branch for the coverage as well.
Configuration is a pretty standard setup (and obviously needs to be called before start):
with a block:
individual lines: