fake language too for code points rankings

[smallst]

now in code points leaderboard we also have language for user. and if it's still undefined we also ignore it instead of query an undefined_icon

Summary by CodeRabbit

• Bug Fixes

  • Enhanced data handling for group sorting, ensuring the system gracefully manages cases with incomplete information.
  • Improved leaderboard styling logic to prevent display issues when certain elements are missing.

• New Features

  • Augmented player details by incorporating users' submitted code language for a richer and more informative experience.

[coderabbitai]

Walkthrough

This pull request introduces minor enhancements in three areas to improve robustness. In the clans module, the sortClan function now uses optional chaining for safer access to clan properties. The seasonal league module has been updated to include a new submittedCodeLanguage property in the player record, capturing the user’s ace configuration language. Finally, the leaderboard component’s style computation now first checks for a valid item, preventing potential runtime errors. The overall functionality remains unchanged.

Changes

File	Change Summary
app/core/.../clans.js	Updated sortClan to use optional chaining for safe clan.slug access.
app/core/.../seasonalLeague.js	Added submittedCodeLanguage to myPlayerRow using aceConfig.language.
app/views/.../Leaderboard.vue	Modified computeStyle to verify that item is truthy before applying styles.

Possibly related PRs

• sort clan by _id:-1 #7694: Focuses on enhancing the robustness of the sortClan function by modifying how clan properties are accessed.

Suggested Reviewers

• mrfinch
• adamkecskes

Poem

I hopped through fields of code so bright,
Dodging nulls and undefined in flight.
With safe chains added to ensure a smooth day,
Each bug and error was chased away.
A joyful rabbit sings in ASCII rhyme,
Celebrating clean code in record time!

Tip

CodeRabbit's docstrings feature is now available as part of our Pro Plan! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. We would love to hear your feedback on Discord.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 58efa59 and c70d197.

📒 Files selected for processing (3)

• app/core/store/modules/clans.js (1 hunks)
• app/core/store/modules/seasonalLeague.js (1 hunks)
• app/views/ladder/components/Leaderboard.vue (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: ESLint CI
• GitHub Check: Node.js CI (18.10.0)

🔇 Additional comments (3)

app/core/store/modules/seasonalLeague.js (1)

609-611: Good addition of the programming language data

This change adds the user's code language to the myPlayerRow object, which aligns with the PR objectives of displaying programming languages in the leaderboard. The optional chaining syntax is a good practice for safely accessing potentially undefined properties.

app/views/ladder/components/Leaderboard.vue (1)

207-207: Improved robustness with null check

Adding the && item condition prevents the code from trying to generate a style for undefined or null language values, which directly addresses the PR objective of properly handling undefined languages instead of querying an undefined_icon.

app/core/store/modules/clans.js (1)

7-9: Added null safety with optional chaining

Good improvement to use optional chaining when accessing clan slug properties. This enhances code robustness by preventing potential errors if a clan object or its slug property is undefined.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.