only show heros in certificate that has poses and signiture

[smallst]

fix ENG-1704

now the certificate fallback to captain if the hero do not have pose

Summary by CodeRabbit

• New Features
  • Enhanced hero selection on certificate displays for improved accuracy. The logic now better determines the appropriate hero role for each certificate, ensuring that your certificate reflects the correct hero representation. Enjoy a smoother certificate verification process.

[coderabbitai]

Walkthrough

The changes update the CertificatesView class by adding trailing commas throughout various objects and callbacks to maintain stylistic consistency. Additionally, the logic for determining hero types is modified: a new heroesWithPose array is introduced, replacing the former direct comparison against 'Warrior' with a check on the slug property. Several callbacks and statistical methods have been updated with these trailing commas without changing their functional behavior.

Changes

File	Change Summary
app/views/.../CertificatesView.js	• Added trailing commas in the events object, success callbacks (for both student and teacher name fetching), and within the statistical calculation methods. • Introduced a new heroesWithPose array and updated the hero determination check to use the slug property instead of comparing to 'Warrior'.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant CV as CertificatesView
    participant S as Server
    U->>CV: Click toggle button
    CV->>CV: Trigger onClickToggleButton event
    CV->>S: Request student name
    S-->>CV: Return student data
    CV->>CV: Process student callback
    CV->>CV: Evaluate hero type using heroesWithPose array
    CV->>S: Request teacher name
    S-->>CV: Return teacher data
    CV->>CV: Process teacher callback

Loading

Poem

I'm a rabbit with a hop and a smile,
Skipping through code, trailing commas in style,
Heroes now pose with a brand-new check,
Slugs and success callbacks, what the heck!
Code flows merry, the features sing and dance—
A joyful update, a whimsical chance!
🐇✨

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)

• We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
  - To enable this feature, set early_access to true under in the settings.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0a18983 and 470e5e1.

📒 Files selected for processing (1)

• app/views/user/CertificatesView.js (6 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: ESLint CI
• GitHub Check: Node.js CI (18.10.0)

🔇 Additional comments (2)

app/views/user/CertificatesView.js (2)

130-134: Improved hero selection logic for certificate display

This change implements the PR objective by creating an explicit list of heroes that have poses and signatures. The code now checks if the hero's slug is in the heroesWithPose array instead of using a more generic class check, ensuring that only heroes with proper visual assets are displayed on certificates.

This is a good approach as it:

1. Makes the supported heroes explicit and easy to update
2. Provides a clear fallback to the captain hero when needed
3. Improves the certificate's visual consistency

---

35-36: Consistent code style with trailing commas

The addition of trailing commas throughout the codebase (in objects, arrays, and function parameters) is a good practice that:

1. Makes future additions cleaner in version control (only one line changes instead of two)
2. Reduces merge conflicts
3. Aligns with modern JavaScript style conventions

Also applies to: 69-70, 150-151, 190-191, 215-216, 217-218

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.