feat: detail_row value styling (font size/weight/color/family + overflow) - #12
Merged
Conversation
…nes/overflow) CofluiDetailRow value is now fully styleable for both native + JSON use: - valueStyle (TextStyle? base) + shorthand merges: valueFontSize, valueFontWeight, valueFontFamily, valueColor - valueMaxLines, valueOverflow (clip/ellipsis/visible/fade) Dynamic-UI detail_row builder exposes the same via JSON props: valueColor (hex), valueFontSize, valueFontWeight (name/number), valueMaxLines, valueOverflow (ellipsis/clip/visible/fade) Tests: 276/276 pass (272 + 4 new). dart analyze lib clean. Backward-compatible: valueColor still works, highlight still works.
|
🌐 Preview deployed: https://3a84afc1.coflui.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the
valuetext indetail_rowfully styleable — for both hand-written widgets and JSON-driven UI.🎨 What changed
CofluiDetailRow (native)
New optional props:
valueStyle: TextStyle?— base style (full control: family, letterSpacing, decoration, …)valueFontSize: double?valueFontWeight: FontWeight?valueFontFamily: String?valueColor: Color?(kept for backward compat — merges on top ofvalueStyle)valueMaxLines: int?valueOverflow: TextOverflow?Merge order: default typography →
valueStyle→ shorthand overrides → final.Dynamic-UI
detail_rowbuilderSame options via JSON props:
{ "type": "detail_row", "props": { "icon": "payments", "label": "Amount", "value": "Rp 1.000.000", "valueFontSize": 20, "valueFontWeight": "bold", "valueColor": "#088ECE", "valueMaxLines": 1, "valueOverflow": "ellipsis" } }valueFontWeight:"bold"|"normal"|"w500"|600|"semibold"| …valueOverflow:"ellipsis"|"clip"|"visible"|"fade"✅ Quality
dart analyze lib= 0 issuesvalueColorandhighlightstill work)Breaking
None — all new fields are optional with defaults that match prior behavior.