Skip to content

perf: remove unused deps + replace deprecated serde_yaml#48

Merged
ajianaz merged 2 commits into
developfrom
chore/deps-audit
May 30, 2026
Merged

perf: remove unused deps + replace deprecated serde_yaml#48
ajianaz merged 2 commits into
developfrom
chore/deps-audit

Conversation

@ajianaz

@ajianaz ajianaz commented May 30, 2026

Copy link
Copy Markdown
Collaborator

Changes

Removed unused dependencies (0 uses each):

  • owo-colors — duplicate of colored
  • thiserror — not used (only anyhow)
  • chrono — no longer needed after SARIF invocation removal

Replaced deprecated dependency:

  • serde_yaml (unmaintained) → serde_yml (active maintained fork)

Optimized tokio features:

  • fullrt-multi-thread,macros — removed networking, fs, io, signal, process features

Impact

Metric Before After Delta
Build time (cold) 2m 52s 1m 03s -56%
Transitive deps 393 377 -16
Binary size 4.8MB 4.8MB Same
Tests 151 pass 151 pass

Related

Removed (0 uses each):
- owo-colors (duplicate of colored)
- thiserror (using anyhow instead)
- chrono (no longer needed after SARIF fix)

Replaced:
- serde_yaml (deprecated) → serde_yml (maintained fork)

Optimized:
- tokio: 'full' → 'rt-multi-thread,macros' (unused features removed)

Results:
- Build time: 2m52s → 1m03s (-56%)
- Transitive deps: 393 → 377 (-16)
- 151 tests pass
@coderabbitai

coderabbitai Bot commented May 30, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@ajianaz, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 30 minutes and 19 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2540f51f-abc0-4d57-b2f3-6f899d03a3ba

📥 Commits

Reviewing files that changed from the base of the PR and between 2b4d7c8 and 7696ef7.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (3)
  • Cargo.toml
  • src/config/schema.rs
  • tests/config_loading.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/deps-audit

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Comment thread Cargo.toml Fixed
@github-actions

github-actions Bot commented May 30, 2026

Copy link
Copy Markdown

🔍 Cora AI Code Review

No issues found. Code looks good!

serde_yml itself is deprecated. serde_yaml_ng v0.10 is the
community-maintained fork with stable API.

151 tests pass.
@ajianaz ajianaz merged commit 2785246 into develop May 30, 2026
9 checks passed
@ajianaz ajianaz deleted the chore/deps-audit branch May 30, 2026 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants