fix(rules+cache): post_match_filter ID mismatch + cache key missing provider/base_url - #479
Merged
Merged
Conversation
ajianaz
force-pushed
the
fix/rule-id-mismatch-and-cache-key
branch
from
August 4, 2026 10:10
f9159e3 to
18da077
Compare
…provider/base_url to cache key Bug 1: post_match_filter ID mismatch (sec-hardcoded-secret vs crypto/hardcoded-secret) - Builtin rule 'sec-hardcoded-secret' was never filtered by post_match_filter because the match arm only checked 'crypto/hardcoded-secret' (security_scanner.rs ID) - Added 'sec-hardcoded-secret' as an alias in the match arm - Added regression tests for builtin rule ID Bug 2: Cache key missing provider and base_url - cache_key() only hashed diff+model+temperature - Switching providers with same model name returned stale cache from previous provider - Added provider and base_url to cache_key, get_cached_review, save_cached_review - Added regression tests for provider/base_url cache isolation Tests: 781 pass (5 new), clippy clean, 6 integration pass
ajianaz
force-pushed
the
fix/rule-id-mismatch-and-cache-key
branch
from
August 4, 2026 10:41
18da077 to
c44724c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes two bugs found during codebase audit:
Bug 1: post_match_filter rule ID mismatch
Bug 2: Cache key missing provider and base_url
Why
let password = ""orlet formSecret = $state("")-- exactly what issue False positives: SVG xmlns, form variable names, and duplicate rule engines #357 was meant to fix, but only half the code paths were coveredTesting
New tests: