feat(install): add --remove, --validate, multi-agent uninstall - #495
Merged
Conversation
Add uninstall mode and post-install validation to cora install: - `cora install --remove`: removes cora MCP entry from all detected agents - `cora install --validate`: validates config files parse correctly after install/remove (JSON/JSONC only, YAML skipped) - Multi-agent config validation with error reporting - Uninstall works for both JSON/JSONC and YAML format agents - Updated MCP tools.rs to include new fields Closes #430
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add
--remove(uninstall) and--validate(post-install config validation) flags tocora install.Why
Issue #430 requires multi-agent config validation and complete install/uninstall lifecycle. Previously
cora installcould only add entries — there was no way to remove Cora from agent configs, and no verification that written configs still parse correctly.How
cora install --removemcpServers.coraentry from all detected agents--dry-runto preview removalcora install --validateChanges
src/commands/install.rs: +uninstall_json_agent(), +validate_json_config(), refactoredinstall_agent()to dispatch install vs remove, refactoredexecute_install()for remove mode + validation blocksrc/main.rs: added--removeand--validateCLI flagssrc/mcp/tools.rs: updated InstallOptions constructionTesting
cargo test --features tree-sitter— 893 pass, 0 failcargo clippy --all-targets --features tree-sitter -- -D warnings— 0 warningscargo fmt --all -- --check— cleanRelated Issues
Closes #430
Checklist