feat(detail): related memories with match bars, fix detail crash - #321
Merged
Conversation
excluding self; semantic badge + % label + mini match bar (uteke- mobile flagship parity); click navigates within the panel - Fixes latent crash surfaced here: load() referenced an undefined `content` variable and a non-existent `uteke.recall` - either threw into the main catch, nulling the memory and rendering "Memory not found." for every valid memory (web mode) Live-verified on uteke 0.17.0 sandbox: 5 semantic hits with match bars, no false not-found state. tsc clean, 91/91 tests, build green. Part of #296, epic #289.
🔍 Cora AI Code Review✅ No issues found. Code looks good! Review powered by cora-code · BYOK · MIT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Related memories section (#296, sisa scope) in the memory detail panel:
semanticbadge, % match label, and a mini match bar (parity with the uteke-mobile flagship pattern)Also fixes a latent bug this work surfaced:
load()referenced an undefinedcontentvariable and a non-existentuteke.recall— either threw into the main catch, nulling the memory and rendering "Memory not found." for every valid memory opened from the Memories list (web mode).Why
Related memories explains why this matters (transparency, P37/P38) and is the proven reading-surface hero pattern from uteke-mobile; #296 tracked it as remaining scope after the author-header/timeline/copy-ID work shipped.
Testing
Part of #296 · Epic #289 · Requires uteke 0.16.0+