fix: standardize default port to 9090 (Dockerfile + README)#274
Merged
Conversation
Dockerfile ENV TRAPFALL_LISTEN + EXPOSE: 3000 → 9090 README: all docker run examples, localhost refs, DSN examples README: CLI default was already 9090 (matches now) Closes #273
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Dockerfile and CLI disagree on default listen port. Dockerfile used 3000, CLI uses 9090.
Changes
Dockerfile:ENV TRAPFALL_LISTEN+EXPOSE3000 → 9090README.md: alldocker run,localhost, DSN examples → 9090Closes #273
Cora Review
cora reviewpassed (1 informational: HTTPS on app port — expected for self-hosted dev setup)