fix(ci): use --help instead of --version for cargo-zigbuild - #959
Merged
Conversation
cargo-zigbuild does not support --version flag, causing set -e to exit. Use --help (which is supported) to verify the binary is accessible.
🔍 Cora AI Code Review✅ No issues found. Code looks good! Review powered by cora-code · BYOK · MIT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix
cargo zigbuild --versionyang menyebabkan CI failure. cargo-zigbuild CLI tidak support--versionflag.Why
PR #957 add
cargo zigbuild --versionsebagai sanity check di install step. Tapi cargo-zigbuild tidak punya--versionflag, jadiset -eexit dengan errorunexpected argument '--version' found. Zig binary path resolution-nya berhasil (zig version jalan), tapi cargo-zigbuild check yang error.Changes
--versionke--help(didukung oleh cargo-zigbuild)/dev/nulluntuk clean logsTesting
CI akan verify install step passes. Release workflow akan verify actual build.