Conversation
cargo-zigbuild fundamentally incompatible with numkong SIMD intrinsics (ARM NEON dot product, x86 AMX). Zig's bundled clang lacks required header support. After 6 PR iterations, zigbuild path issues resolved but compile failures remain. Replace with ubuntu-22.04/22.04-arm runners: - GLIBC 2.35 = Ubuntu 22.04+, Debian 12+, RHEL 9+ (>90% server coverage) - System GCC handles numkong SIMD probes correctly - Zero additional toolchain complexity - Removed: zigbuild install, build step, dynamic bindir resolution - Simplified: single cargo build, static bin dir, warning-only GLIBC check Co-authored-by: ajianaz <ajianaz@users.noreply.github.com>
🔍 Cora AI Code ReviewReview powered by cora-code · BYOK · MIT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Promote zigbuild rollback to main for v0.13.0 re-release.
Why
cargo-zigbuild incompatible with numkong SIMD intrinsics. ubuntu-22.04 runners provide GLIBC 2.35 with zero toolchain complexity.
Changes
Testing