chore: deprecate unused pub fn (dead code cleanup) - #971
Merged
Conversation
- cycle_deprecate_cap (lib.rs) - remember_json (operations.rs) - recall_context (operations.rs) - count_documents (documents.rs) All have zero callers in workspace. Marked #[deprecated] + #[allow(dead_code)] to signal removal intent without breaking downstream API consumers.
🔍 Cora AI Code Review✅ No issues found. Code looks good! Review powered by cora-code · BYOK · MIT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Empat
pub fndengan zero callers di seluruh workspace ditandai#[deprecated]:cycle_deprecate_cap(lib.rs:325) — deprecation cycle cap calculatorremember_json(operations.rs:79) — JSON-specific remember wrapperrecall_context(operations.rs:630) — context-aware recall helpercount_documents(documents.rs:820) — global document countWhy
Cora intelligent scan mendeteksi 4 dead code functions. Karena ini public API di crate
uteke-core, removal langsung akan break downstream consumers.#[deprecated]tag memberi signal removal intent tanpa breaking change.Changes
Setiap function mendapat:
Testing