Skip to content
This repository was archived by the owner on Jan 10, 2023. It is now read-only.

rollback request to v2.77.0#73

Merged
eddiemoore merged 1 commit intocodecov:masterfrom
aoberoi:node-v0.12-compat
Oct 14, 2017
Merged

rollback request to v2.77.0#73
eddiemoore merged 1 commit intocodecov:masterfrom
aoberoi:node-v0.12-compat

Conversation

@aoberoi
Copy link
Copy Markdown
Contributor

@aoberoi aoberoi commented Oct 14, 2017

this is the latest version that is still compatible with node <4.0.
fixes #72

this is the latest version that is still compatible with node <4.0.
fixes codecov#72
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 14, 2017

Codecov Report

Merging #73 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #73   +/-   ##
=======================================
  Coverage   90.53%   90.53%           
=======================================
  Files          18       18           
  Lines         264      264           
  Branches       57       57           
=======================================
  Hits          239      239           
  Misses         25       25

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1d1ace...2fe7ee5. Read the comment docs.

@eddiemoore eddiemoore merged commit ce3d271 into codecov:master Oct 14, 2017
@fguitton
Copy link
Copy Markdown

fguitton commented Oct 19, 2017

Why are we purposefully re-introducing security holes (https://snyk.io/vuln/npm:tunnel-agent:20170305) for the sake of node versions deprecated since April 2016 and expired since late 2016(https://nodejs.org/en/blog/release/v0.12.13/) ?
This was already discussed multiple times on other project as well, including competition:
nickmerwin/node-coveralls#133
nickmerwin/node-coveralls#149
nickmerwin/node-coveralls#153

The request team also migrated away from the problem packages back in November 2016.
I must support #74 1000%

@aoberoi
Copy link
Copy Markdown
Contributor Author

aoberoi commented Oct 19, 2017 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Not compatible on node 0.12 because of request

3 participants