rollback request to v2.77.0#73
Conversation
this is the latest version that is still compatible with node <4.0. fixes codecov#72
Codecov Report
@@ Coverage Diff @@
## master #73 +/- ##
=======================================
Coverage 90.53% 90.53%
=======================================
Files 18 18
Lines 264 264
Branches 57 57
=======================================
Hits 239 239
Misses 25 25Continue to review full report at Codecov.
|
|
Why are we purposefully re-introducing security holes (https://snyk.io/vuln/npm:tunnel-agent:20170305) for the sake of node versions deprecated since April 2016 and expired since late 2016(https://nodejs.org/en/blog/release/v0.12.13/) ? The |
|
If we do the rollback, I urge us to do it as a semver major revision of this
package so that it’s clear that node 0.12 support has ended in the v2.x
series.
In my personal opinion, older than currently supported versions of node are
still valuable in the case of a testing tool. This is a tool that can help
maintainers understand whether their package is compatible on a version of
node, so creating a roadblock in this package prevents them from even
investigating.
…On Thu, Oct 19, 2017 at 2:51 PM Florian Guitton ***@***.***> wrote:
Why are we purposefully re-introducing security holes (
https://snyk.io/vuln/npm:tunnel-agent:20170305) for the sake of node
versions deprecated since April 2016 and expired since late 2016(
https://nodejs.org/en/blog/release/v0.12.13/) ?
This was already discussed multiple times on other project as well,
including competition:
nickmerwin/node-coveralls#133
<nickmerwin/node-coveralls#133>
nickmerwin/node-coveralls#149
<nickmerwin/node-coveralls#149>
nickmerwin/node-coveralls#153
<nickmerwin/node-coveralls#153>
The request team also migrated away from the problem packages back in
November 2016.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#73 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAeMy0uE6INnShfELLD6NFx8t9sZTc2zks5st8R2gaJpZM4P5Oh_>
.
|
this is the latest version that is still compatible with node <4.0.
fixes #72