This repository was archived by the owner on Jan 10, 2023. It is now read-only.
Stop outputting upload-token in logs#97
Merged
eddiemoore merged 1 commit intocodecov:masterfrom May 8, 2018
Merged
Conversation
Instead of dumping `query` object directly, output a selected set of values (don't output the upload_token) Introduced in codecov@4be4171 Closes codecov#94
Contributor
Author
|
@eddiemoore This solves a security issue so would be great to have this merged + released sooner rather than later. |
Codecov Report
@@ Coverage Diff @@
## master #97 +/- ##
=======================================
Coverage 89.17% 89.17%
=======================================
Files 18 18
Lines 268 268
Branches 58 58
=======================================
Hits 239 239
Misses 29 29
Continue to review full report at Codecov.
|
eddiemoore
approved these changes
May 8, 2018
Contributor
Author
|
That was fast! Thanks a lot @eddiemoore! 🎉 |
Collaborator
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of dumping
queryobject directly, output a selected set of values (don't output the upload_token)Introduced in 4be4171
Closes #94