add FieldTracker to Owner - no migration required! #411
Conversation
| objects = OwnerManager() | ||
|
|
||
| tracker = FieldTracker( | ||
| fields=["username", "service", "upload_token_required_for_public_repos"] |
There was a problem hiding this comment.
This is fine, although if you don't specify the fields, then you can track any field you want, so you wouldn't have to make a future PR for this. Pros and cons, this makes it more specific too. I'll leave this up to you!
There was a problem hiding this comment.
yeah I hear that - at the moment I'd like to keep it as slim as possible, so I'll keep it with these specific fields.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #411 +/- ##
==========================================
- Coverage 90.24% 89.81% -0.43%
==========================================
Files 384 324 -60
Lines 11733 9472 -2261
Branches 2058 1688 -370
==========================================
- Hits 10588 8507 -2081
+ Misses 1046 901 -145
+ Partials 99 64 -35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
We have this on
Repositorymodel so we can do this inapi.I'd like to add the same thing for
Ownerto use in the same way inapi.ChatGPT says it's performant 👼
codecov/engineering-team#2299