Skip to content
This repository was archived by the owner on May 5, 2025. It is now read-only.

add FieldTracker to Owner - no migration required! #411

Merged
merged 1 commit into from
Oct 30, 2024
Merged

add FieldTracker to Owner - no migration required! #411

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion shared/django_apps/codecov_auth/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
from django.forms import ValidationError
from django.utils import timezone
from django_prometheus.models import ExportModelOperationsMixin
from model_utils import FieldTracker

from shared.config import get_config
from shared.django_apps.codecov.models import BaseCodecovModel, BaseModel
Expand Down Expand Up @@ -381,7 +382,9 @@ class Meta:
)

objects = OwnerManager()

tracker = FieldTracker(
fields=["username", "service", "upload_token_required_for_public_repos"]
Copy link
Contributor

@adrian-codecov adrian-codecov Oct 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, although if you don't specify the fields, then you can track any field you want, so you wouldn't have to make a future PR for this. Pros and cons, this makes it more specific too. I'll leave this up to you!

Copy link
Member Author

@nora-shap nora-shap Oct 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I hear that - at the moment I'd like to keep it as slim as possible, so I'll keep it with these specific fields.

)
repository_set = RepositoryManager()

def __str__(self):
Expand Down
Loading