Skip to content
This repository was archived by the owner on May 5, 2025. It is now read-only.

chore: fix minio config defaults#562

Merged
joseph-sentry merged 1 commit intomainfrom
joseph/minio-config
Mar 10, 2025
Merged

chore: fix minio config defaults#562
joseph-sentry merged 1 commit intomainfrom
joseph/minio-config

Conversation

@joseph-sentry
Copy link
Copy Markdown
Contributor

No description provided.

@joseph-sentry joseph-sentry requested a review from a team March 10, 2025 17:45
@ghost
Copy link
Copy Markdown

ghost commented Mar 10, 2025

✅ Sentry found no issues in your recent changes ✅

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Mar 10, 2025

CodSpeed Performance Report

Merging #562 will not alter performance

Comparing joseph/minio-config (abdba8e) with main (21d3d12)

Summary

✅ 17 untouched benchmarks

@codecov-notifications
Copy link
Copy Markdown

codecov-notifications Bot commented Mar 10, 2025

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
shared/storage/minio.py 25.00% 3 Missing and 3 partials ⚠️

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 10, 2025

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 88.63%. Comparing base (21d3d12) to head (abdba8e).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
shared/storage/minio.py 25.00% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #562      +/-   ##
==========================================
- Coverage   88.68%   88.63%   -0.05%     
==========================================
  Files         461      461              
  Lines       13184    13192       +8     
  Branches     1515     1519       +4     
==========================================
+ Hits        11692    11693       +1     
- Misses       1170     1173       +3     
- Partials      322      326       +4     
Flag Coverage Δ
shared-docker-uploader 88.63% <25.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joseph-sentry joseph-sentry added this pull request to the merge queue Mar 10, 2025
Merged via the queue into main with commit f9affa0 Mar 10, 2025
@joseph-sentry joseph-sentry deleted the joseph/minio-config branch March 10, 2025 19:42
Swatinem added a commit that referenced this pull request Mar 12, 2025
github-merge-queue Bot pushed a commit that referenced this pull request Mar 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants