Skip to content
This repository was archived by the owner on May 5, 2025. It is now read-only.

Revert "chore: fix minio config defaults (#562)"#567

Merged
Swatinem merged 1 commit intomainfrom
revert-minio-port
Mar 12, 2025
Merged

Revert "chore: fix minio config defaults (#562)"#567
Swatinem merged 1 commit intomainfrom
revert-minio-port

Conversation

@Swatinem
Copy link
Copy Markdown
Contributor

This reverts #562, which I believe has caused
WORKER-RPN and similar problems, which have caused problems when deploying the update in worker.

@Swatinem Swatinem requested review from a team and joseph-sentry March 12, 2025 08:47
@Swatinem Swatinem self-assigned this Mar 12, 2025
@ghost
Copy link
Copy Markdown

ghost commented Mar 12, 2025

✅ Sentry found no issues in your recent changes ✅

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.90%. Comparing base (0e62878) to head (bafc3b3).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #567      +/-   ##
==========================================
+ Coverage   88.88%   88.90%   +0.01%     
==========================================
  Files         462      462              
  Lines       13218    13210       -8     
  Branches     1520     1516       -4     
==========================================
- Hits        11749    11744       -5     
+ Misses       1144     1143       -1     
+ Partials      325      323       -2     
Flag Coverage Δ
shared-docker-uploader 88.90% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Swatinem Swatinem enabled auto-merge March 12, 2025 08:57
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Mar 12, 2025

CodSpeed Performance Report

Merging #567 will not alter performance

Comparing revert-minio-port (bafc3b3) with main (0e62878)

Summary

✅ 17 untouched benchmarks

@Swatinem Swatinem added this pull request to the merge queue Mar 12, 2025
Merged via the queue into main with commit 82e98e5 Mar 12, 2025
11 checks passed
@Swatinem Swatinem deleted the revert-minio-port branch March 12, 2025 09:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants