Skip to content

i added my son#47

Merged
oohwooh merged 14 commits into
codeday:mainfrom
hawa-mani:elizza-cow
Jul 19, 2026
Merged

i added my son#47
oohwooh merged 14 commits into
codeday:mainfrom
hawa-mani:elizza-cow

Conversation

@hawa-mani

@hawa-mani hawa-mani commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

adding mao - the cat. hes also a cow
he kinda looks cow-esque
but also not

verified all required fields are available
removed the other image file i dont want anymore
mao
Screenshot 2026-07-18 at 12 37 08 PM

@github-actions

Copy link
Copy Markdown

🧪 PR Validation Results for #47


❌ File cows/elizza-cow.json is missing: name. These are required for further validation.

@cla-assistant

cla-assistant Bot commented Jul 18, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@github-actions

Copy link
Copy Markdown

🧪 PR Validation Results for #47

Check PR is going to correct repo passed!
Check image path passed!
Check image file exists passed!
Check image file size passed!
❌ Image file name in cows/elizza-cow.json should be based on the cow's name. Expected: images/nemo_the_turtle.png or .jpg or .jpeg
❌ File cows/elizza-cow.json is not properly indented.
Check line endings passed!


❌ 5/7 passed. Please fix the issues above and update your PR.

@github-actions

Copy link
Copy Markdown

🧪 PR Validation Results for #47

Check PR is going to correct repo passed!
Check image path passed!
Check image file exists passed!
Check image file size passed!
❌ Image file name in cows/nemo_the_turtle.json should be based on the cow's name. Expected: images/nemo_the_turtle.png or .jpg or .jpeg
❌ File cows/nemo_the_turtle.json is not properly indented.
Check line endings passed!


❌ 5/7 passed. Please fix the issues above and update your PR.

@github-actions

Copy link
Copy Markdown

🧪 PR Validation Results for #47

Check PR is going to correct repo passed!
Check image path passed!
Check image file exists passed!
❌ Image file is too large! Maximum allowed size is 200 KB. Please resize or compress it and update your PR.
Check file naming convention passed!
❌ File cows/nemo_the_turtle.json is not properly indented.
Check line endings passed!


❌ 5/7 passed. Please fix the issues above and update your PR.

⚠️ You have 3 previous failed validation attempts. Please schedule a CSE session using your student dashboard.

@oohwooh

oohwooh commented Jul 18, 2026

Copy link
Copy Markdown
Member

Hi @hawa-mani - thanks so much for your contribution, I love your cow!

We'd love to merge your PR, can you please fix the issues identified?

Please feel free to reach out if you have any questions or need help :)

working on things
@github-actions

Copy link
Copy Markdown

🧪 PR Validation Results for #47

Check PR is going to correct repo passed!
Check image path passed!
Check image file exists passed!
❌ Image file is too large! Maximum allowed size is 200 KB. Please resize or compress it and update your PR.
Check file naming convention passed!
❌ File cows/mao.json is not properly indented.
Check line endings passed!


❌ 5/7 passed. Please fix the issues above and update your PR.

⚠️ You have 4 previous failed validation attempts. Please schedule a CSE session using your student dashboard.

@github-actions

Copy link
Copy Markdown

🧪 PR Validation Results for #47

Check PR is going to correct repo passed!
Check image path passed!
Check image file exists passed!
❌ Image file is too large! Maximum allowed size is 200 KB. Please resize or compress it and update your PR.
Check file naming convention passed!
❌ File cows/mao.json is not properly indented.
Check line endings passed!


❌ 5/7 passed. Please fix the issues above and update your PR.

⚠️ You have 5 previous failed validation attempts. Please schedule a CSE session using your student dashboard.

@github-actions

Copy link
Copy Markdown

🧪 PR Validation Results for #47

Check PR is going to correct repo passed!
Check image path passed!
Check image file exists passed!
❌ Image file is too large! Maximum allowed size is 200 KB. Please resize or compress it and update your PR.
Check file naming convention passed!
❌ File cows/mao.json is not properly indented.
Check line endings passed!


❌ 5/7 passed. Please fix the issues above and update your PR.

⚠️ You have 6 previous failed validation attempts. Please schedule a CSE session using your student dashboard.

@github-actions

Copy link
Copy Markdown

🧪 PR Validation Results for #47

Check PR is going to correct repo passed!
Check image path passed!
Check image file exists passed!
❌ Image file is too large! Maximum allowed size is 200 KB. Please resize or compress it and update your PR.
Check file naming convention passed!
❌ File cows/mao.json is not properly indented.
Check line endings passed!


❌ 5/7 passed. Please fix the issues above and update your PR.

⚠️ You have 7 previous failed validation attempts. Please schedule a CSE session using your student dashboard.

@github-actions

Copy link
Copy Markdown

🧪 PR Validation Results for #47

Check PR is going to correct repo passed!
Check image path passed!
Check image file exists passed!
❌ Image file is too large! Maximum allowed size is 200 KB. Please resize or compress it and update your PR.
Check file naming convention passed!
❌ File cows/mao.json is not properly indented.
Check line endings passed!


❌ 5/7 passed. Please fix the issues above and update your PR.

⚠️ You have 8 previous failed validation attempts. Please schedule a CSE session using your student dashboard.

@github-actions

Copy link
Copy Markdown

🧪 PR Validation Results for #47

Check PR is going to correct repo passed!
Check image path passed!
Check image file exists passed!
❌ Image file is too large! Maximum allowed size is 200 KB. Please resize or compress it and update your PR.
Check file naming convention passed!
Check proper indentation passed!
Check line endings passed!


❌ 6/7 passed. Please fix the issues above and update your PR.

⚠️ You have 9 previous failed validation attempts. Please schedule a CSE session using your student dashboard.

@github-actions

Copy link
Copy Markdown

🧪 PR Validation Results for #47

Check PR is going to correct repo passed!
Check image path passed!
Check image file exists passed!
Check image file size passed!
Check file naming convention passed!
Check proper indentation passed!
Check line endings passed!


✅ All tests passed! Nice work on your PR! 🎉

@github-actions

Copy link
Copy Markdown

🧪 PR Validation Results for #47

Check PR is going to correct repo passed!
Check image path passed!
Check image file exists passed!
Check image file size passed!
Check file naming convention passed!
Check proper indentation passed!
Check line endings passed!


✅ All tests passed! Nice work on your PR! 🎉

@hawa-mani

Copy link
Copy Markdown
Contributor Author

meep signed it

@hawa-mani

Copy link
Copy Markdown
Contributor Author

hmm ***

@hawa-mani
hawa-mani marked this pull request as draft July 18, 2026 20:45
@hawa-mani
hawa-mani marked this pull request as ready for review July 18, 2026 20:45
@hawa-mani

Copy link
Copy Markdown
Contributor Author

rah -- made both accounts sign, but issues fixed , should be cooking now

@oohwooh oohwooh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love your cow!! Please see my review for a couple things that need to be done before merge. I will be at sprints soon if you would like my help in person :)

Comment thread .DS_Store Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please remove this file? You should be able to use git rm

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oki i shall remove this file

Comment thread .gitignore

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is redundant, can you remove it? (I think it's due to automatic merge? Since I made the .gitignore after your fork)

@hawa-mani hawa-mani Jul 19, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oki -- will remove this update

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I also made a .gitignore yesterday on my end -- but lemme know if I should do anything moore here --
I think the only thing I changed was to match the ordering of it in codeday:main

@github-actions

Copy link
Copy Markdown

🧪 PR Validation Results for #47

Check PR is going to correct repo passed!
Check image path passed!
Check image file exists passed!
Check image file size passed!
Check file naming convention passed!
Check proper indentation passed!
Check line endings passed!


✅ All tests passed! Nice work on your PR! 🎉

@hawa-mani hawa-mani left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes:
deleted the ds_store file
changed my gitignore to match codeday:main

Comment thread .gitignore

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I also made a .gitignore yesterday on my end -- but lemme know if I should do anything moore here --
I think the only thing I changed was to match the ordering of it in codeday:main

@oohwooh oohwooh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oohwooh

oohwooh commented Jul 19, 2026

Copy link
Copy Markdown
Member

Thanks so much for the cow-tribution!

@oohwooh
oohwooh merged commit f4e9f54 into codeday:main Jul 19, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants