Support copilot: make role-add extraction AI-first#3593
Merged
Conversation
The role-add action now takes the role and target emails from the Cursor triage result (emails via the case target/secondary fields, role via new role_name/role_operation triage outputs), falling back to the deterministic SupportRoleRequestParser only when triage produced nothing usable. - Cursor triage schema + prompt now emit role_name/role_operation - heuristic triage exposes the same fields so the schema is stable - new SupportRoleRequestResolver centralises AI-first-with-parser-fallback - UserRoleAddService and proposedActionForCase use the resolver - dry-run + APPROVE gate is unchanged; reviewer still confirms the full list Tests: resolver AI-first + fallback, plus existing role/email copy suites. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SupportRoleRequestParseronly as a fallback when triage produced nothing usable.role_name/role_operation; the heuristic triage exposes the same fields so the merged schema is stable.SupportRoleRequestResolvercentralises the AI-first-with-parser-fallback logic;UserRoleAddServiceandproposedActionForCaseboth use it.Test plan
SupportRoleRequestResolverTest— AI-first resolution and parser fallbackUserRoleAddServiceTest,SupportRoleRequestParserTestSupportDryRunEmailCopyTest,SupportCompletionEmailCopyTest,SupportApprovalCompletionEmailTestMade with Cursor