Support copilot: fix email subject mojibake + role-add completion tense#3596
Merged
Conversation
…ense - MIME-encode (RFC 2047) the outgoing Subject header so non-ASCII characters (em-dash, accents in names) are no longer mangled into "—". - Completion email now reads "role added" for accounts actually changed, instead of "will be added"; dry-run still reads "will be added". Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Subject:header was emitted as raw UTF-8, so characters like the em-dash—and accented names showed as—. It's now RFC 2047 MIME-encoded (only when it contains non-ASCII), viamb_encode_mimeheaderwith a base64 fallback.addedstatus to "will be added". It now reads "role added" for accounts actually changed; the dry-run still reads "will be added" (would_add).Test plan
SupportCompletionEmailCopyTest::test_completion_body_for_role_add_uses_past_tense_per_accountMade with Cursor