fix(cli): match tag.skipPackages as glob patterns - #529
Merged
Conversation
The release `Publish packages` step failed because `codefast tag` tried to tag `@apps/start-demo` — a private, version-less app added in #528 — and threw "Missing or invalid version", exiting non-zero. Make `tag.skipPackages` entries match package names as glob patterns (picomatch), so a single `@apps/*` skips every private app instead of naming each one. The "compile a pattern list, match any" logic, previously duplicated in workspace-package discovery, is extracted to a shared `createAnyGlobMatcher` helper in `core/glob.ts`; both the resolver excludes and tag skip-list now use it. `.changeset/config.json` ignore is simplified to `@apps/*` too (Changesets matches it via micromatch).
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Codecov Report❌ Patch coverage is
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Export and directly unit-test filterSkippedCandidates: scope-glob skipping (`@apps/*`), backward-compatible exact-name matching, and that candidates without a package name (explicit targets) are never skipped. Covers the tag skip-list call site flagged by patch coverage.
thevuong
added a commit
that referenced
this pull request
Jun 28, 2026
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ `main` is currently in **pre mode** so this branch has prereleases rather than normal releases. If you want to exit prereleases, run `changeset pre exit` on `main`.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ # Releases ## @codefast/theme@0.5.0-canary.0 ### Minor Changes - [#526](#526) [`fad5a21`](fad5a21) Thanks [@thevuong](https://github.com/thevuong)! - Add the `@codefast/theme/vite` plugin. TanStack Start registers the server functions shipped in `@codefast/theme/start` at the consumer's build time, so the package must not be externalized for SSR nor pre-bundled for the client. The new `codefastTheme()` plugin applies that configuration automatically, so consumers no longer need to hand-write `ssr.noExternal` / `optimizeDeps.exclude`. ## @codefast/cli@0.5.0-canary.0 ### Patch Changes - [#529](#529) [`ca90f1c`](ca90f1c) Thanks [@thevuong](https://github.com/thevuong)! - `codefast tag` now matches `tag.skipPackages` entries as glob patterns (picomatch), so a single `@apps/*` entry skips every private app instead of listing each by name. This fixes the release `Publish packages` step failing on `@apps/start-demo` (a private, version-less app the command tried to tag). The compile-patterns-then-match-any logic is now shared via a single `createAnyGlobMatcher` helper, also used by workspace-package discovery. ## @codefast/ui@0.5.0-canary.0 ### Patch Changes - Updated dependencies \[]: - @codefast/tailwind-variants@0.5.0-canary.0 ## @codefast/di@0.5.0-canary.0 ## @codefast/tailwind-variants@0.5.0-canary.0 ## @codefast/typescript-config@0.5.0-canary.0 ## @codefast/benchmark-di-inversify@0.5.0-canary.0 ### Patch Changes - Updated dependencies \[]: - @codefast/benchmark-harness@0.5.0-canary.0 - @codefast/benchmark-viewer@0.5.0-canary.0 - @codefast/di@0.5.0-canary.0 ## @codefast/benchmark-tailwind-variants@0.5.0-canary.0 ### Patch Changes - Updated dependencies \[]: - @codefast/benchmark-harness@0.5.0-canary.0 - @codefast/benchmark-viewer@0.5.0-canary.0 - @codefast/tailwind-variants@0.5.0-canary.0 ## @codefast/benchmark-viewer@0.5.0-canary.0 ### Patch Changes - Updated dependencies \[]: - @codefast/benchmark-harness@0.5.0-canary.0 - @codefast/tailwind-variants@0.5.0-canary.0 ## @codefast/benchmark-harness@0.5.0-canary.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The release Publish packages → Version and publish step (failed run) on
main:version-packagesrunschangeset version && codefast tag.codefast tagscans every workspace package to add@sinceJSDoc tags. After #528 addedapps/start-demo— a private, version-less app — the command treated it as a target,resolveNearestPackageVersionthrewMissing or invalid version, and the publish job exited non-zero.tag.skipPackagesalready excluded@apps/web(same kind of private app), but only via exact-name matching, so every new app had to be listed by hand.What changed
tag.skipPackagesnow matches entries as glob patterns (picomatch). A single@apps/*skips every private app under the scope; exact names like@apps/webstill work unchanged (backward compatible).resolver.ts) and the new tag skip-list. Extracted into one shared helpercreateAnyGlobMatcherinpackages/cli/src/core/glob.ts; both call sites now use it. (No throwaway wrapper — the helper is the single source of truth.)codefast.config.js:skipPackages: ["@apps/web", "@apps/start-demo"]→["@apps/*"]..changeset/config.json:ignoresimplified to["@apps/*"](Changesets 3.1.4 matchesignoreentries via micromatch — verified).@codefast/clipatch changeset.Verification
pnpm --filter @codefast/cli build+tsgo --noEmit+oxlint --deny-warnings+oxfmt: pass.@codefast/cliunit tests 27/27 pass (newtests/unit/core/glob.test.tscovers exact /@apps/*scope / no-cross-// multi-pattern /dotoption).codefast tag --dry-run: resolved targets 11 → 10, Skipped: 2 (both@apps/*apps), exit 0 (was exit 1).Note for reviewer
@sincetags are intentionally omitted from the newcore/glob.tsexports — the release pipeline (codefast tag) stamps them automatically at version time.