Skip to content

⚡️ Speed up method AsyncV1SocketClient._is_binary_message by 29% #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method AsyncV1SocketClient._is_binary_message by 29% #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/deepgram/agent/v1/socket_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,10 @@ def __init__(self, *, websocket: WebSocketClientProtocol):

def _is_binary_message(self, message: typing.Any) -> bool:
"""Determine if a message is binary data."""
return isinstance(message, (bytes, bytearray))
# Use type() directly for consistent performance (avoids isinstance+tuple overhead for simple cases),
# but preserves behavioral correctness for both bytes/bytearray
t = type(message)
return t is bytes or t is bytearray

def _handle_binary_message(self, message: bytes) -> typing.Any:
"""Handle a binary message (returns as-is for audio chunks)."""
Expand Down