Support hosted OAuth callback handoff for all connectors - #132
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex reviewNo high-confidence issues found. |
Collaborator
Author
|
Fixed the Codex review issue in 7419a3c. Hosted callback handoff now requires an explicit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
redirect_uri, and exchange with hostedexchange_redirect_uriwhen returned by the broker.hosted_callback_handoff: true, and cover that compatibility path for every OAuth connector.Test Plan
Deployment Gate
Before deploying/enabling hosted callbacks, register the per-connector HTTPS callback URLs in the provider apps. The Google OAuth app must include the Google Docs, Google Calendar, and Gmail callback paths. This external dashboard registration was not verified locally.