[Legislator Page] pipe in Maple profile#2181
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Mephistic
left a comment
Mephistic
left a comment
There was a problem hiding this comment.
Looks fine to me - the one real blocker is we just need to address the public query issue I slacked you about so this will work in the deployed environments. Adding the where("public", "==", true) filter is IMO the simplest fix.
I'm sure we'll play around a little bit with the layout of the skeleton as we get closer to launch, so we can dig more into the editing experience as we get user feedback.
| const [legislatorId, setLegislatorId] = useState("") | ||
| const [legislatorData, setLegislatorData] = useState<any[]>([]) | ||
|
|
||
| async function getLegislatorUID(memberCode: string) { |
There was a problem hiding this comment.
nit: It might be useful to make this a method in the db/profile/profile.ts file for reuseability: something like getProfileForLegislator(memberCode: string) that returns a LegislatorProfile | null, where LegislatorProfile is a new type that decorates Profile with the new legislator-specific fields we need. IMO not a blocker here though.
2 participants
Summary
Connect Maple Profiles with corresponding Legislator Pages via memberCode
Checklist
Screenshots
Known issues
used a rule to temporarily address this error, but it ultimately reverted and the error returned:
presumably a permanent change to Firebase's rules would resolve this
Steps to test/reproduce