Skip to content

Finance scrapper - #2209

Merged
Mephistic merged 4 commits into
codeforboston:mainfrom
J-C-L:finance-scrapper
Jul 29, 2026
Merged

Finance scrapper#2209
Mephistic merged 4 commits into
codeforboston:mainfrom
J-C-L:finance-scrapper

Conversation

@J-C-L

@J-C-L J-C-L commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

Summary

This PR makes improvements to the legislator pages' finance tab.
Key improvements:

  • Added election cycle start balance to Firestore, so it's available to display to users. This will reduce confusion about why a legislator's "total spent" can exceed their "total raised".
  • Removed non-contribution receipts from total received on finance tab. This matched OCPF's calculations on their summary pages, and will reduce confusion due to the sum of the contributions breakdown differing from the total raised.
  • Added committee lifecycle reports (ex campaign dissolution) to the exclusion list to prevent double-counting with bank reports for Total Raised.

Checklist

  • [Y] On the frontend, I've made my strings translate-able.
  • [N/A] If I've added shared components, I've added a storybook story.
  • [N/A] I've made pages responsive and look good on mobile.
  • [N/A] If I've added new Firestore queries, I've added any new required indexes to firestore.indexes.json (Please do not only create indexes through the Firebase Web UI, even though the error messages may reccommend it - indexes created this way may be obliterated by subsequent deploys)

@vercel

vercel Bot commented Jul 29, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
maple-dev Ready Ready Preview, Comment Jul 29, 2026 12:28am

Request Review

@Mephistic
Mephistic merged commit f5c8005 into codeforboston:main Jul 29, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants