Bug: BaseCommand $params Type

[MGatner]

PHP Version

7.4

CodeIgniter4 Version

develop

CodeIgniter4 Installation Method

Git

Which operating systems have you tested for this bug?

Linux

Which server did you use?

cli

Database

No response

What happened?

I believe that the typing on BaseCommand::run() was supposed to be @param array<int, string> $params (a "list" of strings), not @param array<string, mixed> $params (string keys, mixed values).

CodeIgniter4/system/CLI/BaseCommand.php

Lines 96 to 101 in bca263c

	/**
	* Actually execute a command.
	*
	* @param array<string, mixed> $params
	*/
	abstract public function run(array $params);

I started tracing this back and it was taking too long but should be quick follow-up at some point.

Steps to Reproduce

See code

Expected Output

See code

Anything else?

No response

[kenjis]

$ php spark make:migration Test --table table

CodeIgniter v4.1.9 Command Line Tool - Server Time: 2022-04-27 16:24:57 UTC-05:00


┌────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┐
│ $params                                                                                                                                        │
└────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┘
array (2) [
    0 => string (4) "Test"
    'table' => string (5) "table"
]
══════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════
Called from .../system/Commands/Generators/MigrationGenerator.php:80 [dd()]

[kenjis]

$params comes from $_SERVER['argv'].

CodeIgniter4/system/HTTP/CLIRequest.php

Line 180 in bca263c

$args = $this->getServer('argv');

@param array<int|string, string> $params is correct.

[kenjis]

I sent a PR #5927

[MGatner]

Ah it has both types. Okay thanks for clarifying - I made a mistake on the Myth:Auth analysis (or failed to fix a preexisting mistake).

[kenjis]

@param array<int|string, string|null> $params is correct.
When options has no value (e.g. php spark foo --sort), the value will be null.