docs: fix BaseCommand $params @param#5927
Merged
kenjis merged 4 commits intocodeigniter4:developfrom Apr 28, 2022
Merged
Conversation
| * Actually execute a command. | ||
| * | ||
| * @param array<string, mixed> $params | ||
| * @param array<int|string, string> $params |
Member
There was a problem hiding this comment.
How about if the option is used as a flag (i.e. without values)? php spark foo --sort
I think the value would be true or null? Not sure which one.
Member
There was a problem hiding this comment.
Ah yes. The true is when you use CLI::getOption() to get the value.
paulbalandan
approved these changes
Apr 28, 2022
MGatner
approved these changes
Apr 28, 2022
Member
MGatner
left a comment
There was a problem hiding this comment.
I noticed that PHPStan released 1.6.2 and it had a significant different set of detection where I was working on Myth:Auth - probably the same source here.
Thanks for the quick fix in the command types!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5926
I got the following errors, so I also fixed them.
https://github.com/codeigniter4/CodeIgniter4/runs/6201648310?check_suite_focus=true
Checklist: