4.7.4 Ready code#10380
Merged
Merged
Conversation
Updates the requirements on [boundwize/structarmed](https://github.com/boundwize/structarmed) to permit the latest version. Updates `boundwize/structarmed` to 0.7.6 - [Release notes](https://github.com/boundwize/structarmed/releases) - [Commits](boundwize/structarmed@0.6.15...0.7.6) --- updated-dependencies: - dependency-name: boundwize/structarmed dependency-version: 0.7.6 dependency-type: direct:development dependency-group: composer-dependencies ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Updates the requirements on [boundwize/structarmed](https://github.com/boundwize/structarmed) to permit the latest version. Updates `boundwize/structarmed` to 0.7.10 - [Release notes](https://github.com/boundwize/structarmed/releases) - [Commits](boundwize/structarmed@0.7.6...0.7.10) --- updated-dependencies: - dependency-name: boundwize/structarmed dependency-version: 0.7.10 dependency-type: direct:development dependency-group: composer-dependencies ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…10241) Updates the requirements on [boundwize/structarmed](https://github.com/boundwize/structarmed) and [rector/rector](https://github.com/rectorphp/rector) to permit the latest version. Updates `boundwize/structarmed` to 0.7.12 - [Release notes](https://github.com/boundwize/structarmed/releases) - [Commits](boundwize/structarmed@0.7.10...0.7.12) Updates `rector/rector` to 2.4.5 - [Release notes](https://github.com/rectorphp/rector/releases) - [Commits](rectorphp/rector@2.4.4...2.4.5) --- updated-dependencies: - dependency-name: boundwize/structarmed dependency-version: 0.7.12 dependency-type: direct:development dependency-group: composer-dependencies - dependency-name: rector/rector dependency-version: 2.4.5 dependency-type: direct:development dependency-group: composer-dependencies ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Updates the requirements on [boundwize/structarmed](https://github.com/boundwize/structarmed) to permit the latest version. Updates `boundwize/structarmed` to 0.8.0 - [Release notes](https://github.com/boundwize/structarmed/releases) - [Commits](boundwize/structarmed@0.7.12...0.8.0) --- updated-dependencies: - dependency-name: boundwize/structarmed dependency-version: 0.8.0 dependency-type: direct:development dependency-group: composer-dependencies ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Updates the requirements on [boundwize/structarmed](https://github.com/boundwize/structarmed) to permit the latest version. Updates `boundwize/structarmed` to 0.8.1 - [Release notes](https://github.com/boundwize/structarmed/releases) - [Commits](boundwize/structarmed@0.8.0...0.8.1) --- updated-dependencies: - dependency-name: boundwize/structarmed dependency-version: 0.8.1 dependency-type: direct:development dependency-group: composer-dependencies ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Updates the requirements on [boundwize/structarmed](https://github.com/boundwize/structarmed) to permit the latest version. Updates `boundwize/structarmed` to 0.9.1 - [Release notes](https://github.com/boundwize/structarmed/releases) - [Commits](boundwize/structarmed@0.8.1...0.9.1) --- updated-dependencies: - dependency-name: boundwize/structarmed dependency-version: 0.9.1 dependency-type: direct:development dependency-group: composer-dependencies ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: memleakd <121398829+memleakd@users.noreply.github.com>
Signed-off-by: memleakd <121398829+memleakd@users.noreply.github.com>
Bumps [actions/checkout](https://github.com/actions/checkout) in `/` from 6.0.2 to 6.0.3. Updates `actions/checkout` from 6.0.2 to 6.0.3 - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@de0fac2...df4cb1c) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: 6.0.3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github_actions ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Updates the requirements on [boundwize/structarmed](https://github.com/boundwize/structarmed) to permit the latest version. Updates `boundwize/structarmed` to 0.11.1 - [Release notes](https://github.com/boundwize/structarmed/releases) - [Commits](boundwize/structarmed@0.11.0...0.11.1) --- updated-dependencies: - dependency-name: boundwize/structarmed dependency-version: 0.11.1 dependency-type: direct:development dependency-group: composer-dependencies ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* chore: handle intentional d() calls in static analysis * chore: update PHPStan baseline for intentional d() calls
Updates the requirements on [boundwize/structarmed](https://github.com/boundwize/structarmed) to permit the latest version. Updates `boundwize/structarmed` to 0.12.0 - [Release notes](https://github.com/boundwize/structarmed/releases) - [Commits](boundwize/structarmed@0.11.1...0.12.0) --- updated-dependencies: - dependency-name: boundwize/structarmed dependency-version: 0.12.0 dependency-type: direct:development dependency-group: composer-dependencies ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…Object and add null fallback (#10257)
Updates the requirements on [boundwize/structarmed](https://github.com/boundwize/structarmed) to permit the latest version. Updates `boundwize/structarmed` to 0.12.5 - [Release notes](https://github.com/boundwize/structarmed/releases) - [Commits](boundwize/structarmed@0.12.0...0.12.5) --- updated-dependencies: - dependency-name: boundwize/structarmed dependency-version: 0.12.5 dependency-type: direct:development dependency-group: composer-dependencies ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Updates the requirements on [boundwize/structarmed](https://github.com/boundwize/structarmed) to permit the latest version. Updates `boundwize/structarmed` to 0.12.6 - [Release notes](https://github.com/boundwize/structarmed/releases) - [Commits](boundwize/structarmed@0.12.5...0.12.6) --- updated-dependencies: - dependency-name: boundwize/structarmed dependency-version: 0.12.6 dependency-type: direct:development dependency-group: composer-dependencies ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [shivammathur/setup-php](https://github.com/shivammathur/setup-php) in `/` from 2.37.1 to 2.37.2. Updates `shivammathur/setup-php` from 2.37.1 to 2.37.2 - [Release notes](https://github.com/shivammathur/setup-php/releases) - [Commits](shivammathur/setup-php@7c071df...f3e473d) --- updated-dependencies: - dependency-name: shivammathur/setup-php dependency-version: 2.37.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github_actions ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…10258) * fix: pass $recursive parameter to parent in Model::objectToRawArray * Update tests/system/Models/ObjectToRawArrayModelTest.php Co-authored-by: Michal Sniatala <michal@sniatala.pl> * fix: remove redundant objectToRawArray method and update changelog * Update tests/system/Models/ObjectToRawArrayModelTest.php Co-authored-by: Michal Sniatala <michal@sniatala.pl> * Update tests/system/Models/ObjectToRawArrayModelTest.php Co-authored-by: Michal Sniatala <michal@sniatala.pl> * Update test comment: indicate fix for model‑recursive PR #10258 * test: Fix PHPStan missing type in callObjectToRawArray * style: remove redundant comment in ObjectToRawArrayModelTest.php --------- Co-authored-by: Michal Sniatala <michal@sniatala.pl>
…0303) * fix(Filters): check both keys and values in InvalidChars arrays * test(Filters): use DataProvider for InvalidChars control characters test * style: fix PHPStan iterable return type in tests * chore: re-trigger CI * docs: update changelog for InvalidChars array keys fix
* fix: use dynamic lockMaxRetries limit in RedisHandler * fix: read correct config property names in RedisHandler lockSession * fix: add lockMaxRetries test and remove stale PHPStan baseline entries * fix: add setLogger to RedisHandlerTest to prevent null logger error * Update system/Session/Handlers/RedisHandler.php Co-authored-by: Michal Sniatala <michal@sniatala.pl> * Fix PHPStan warnings for RedisHandler and update changelog * Update user_guide_src/source/changelogs/v4.7.4.rst Co-authored-by: Michal Sniatala <michal@sniatala.pl> * docs: alphabetize changelog entries and properties in v4.7.4.rst --------- Co-authored-by: Michal Sniatala <michal@sniatala.pl>
…es (#10305) * fix: env() TypeError for non-string $_SERVER values + esc() fixes - env(): guard non-string values (int argc, array argv in CLI) before strtolower() to prevent TypeError under declare(strict_types=1) - esc(): propagate $encoding in recursive array calls (was ignored before), add early return after array processing, replace single static $escaper with static $escapers[] cache keyed by encoding - tests: data-provider test for env() non-string types, three tests for esc() foreach reference leak * Apply suggestion from @michalsn Co-authored-by: Michal Sniatala <michal@sniatala.pl> * Apply suggestion from @michalsn Co-authored-by: Michal Sniatala <michal@sniatala.pl> * Update system/Common.php Co-authored-by: Michal Sniatala <michal@sniatala.pl> * style: cs-fix * test: add tests for esc() encoding changes and update changelog * Update tests/system/CommonFunctionsTest.php Co-authored-by: Michal Sniatala <michal@sniatala.pl> * docs: move env/esc fix changelog entry to v4.7.4.rst * docs: split Common changelog entry --------- Co-authored-by: Michal Sniatala <michal@sniatala.pl>
Updates the requirements on [boundwize/structarmed](https://github.com/boundwize/structarmed) to permit the latest version. Updates `boundwize/structarmed` to 0.13.4 - [Release notes](https://github.com/boundwize/structarmed/releases) - [Commits](boundwize/structarmed@0.12.6...0.13.4) --- updated-dependencies: - dependency-name: boundwize/structarmed dependency-version: 0.13.4 dependency-type: direct:development dependency-group: composer-dependencies ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…0330) * refactor(HTTP): optimize download() file path processing and add extreme filename test * Update tests/system/HTTP/ResponseTest.php Co-authored-by: Michal Sniatala <michal@sniatala.pl> * Update tests/system/HTTP/ResponseTest.php Co-authored-by: Michal Sniatala <michal@sniatala.pl> * Update tests/system/HTTP/ResponseTest.php Co-authored-by: Michal Sniatala <michal@sniatala.pl> * chore(changelog): remove download optimization entry as it is a refactoring * fix: remove duplicated temporary directory creation in test --------- Co-authored-by: Michal Sniatala <michal@sniatala.pl>
* Fix phpini check for null ini values * test: cover phpini null ini values * docs: add phpini null value changelog
Updates the requirements on [boundwize/structarmed](https://github.com/boundwize/structarmed) to permit the latest version. Updates `boundwize/structarmed` to 0.14.6 - [Release notes](https://github.com/boundwize/structarmed/releases) - [Commits](boundwize/structarmed@0.13.8...0.14.6) --- updated-dependencies: - dependency-name: boundwize/structarmed dependency-version: 0.14.6 dependency-type: direct:development dependency-group: composer-dependencies ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/cache](https://github.com/actions/cache) in `/` from 6.0.0 to 6.1.0. Updates `actions/cache` from 6.0.0 to 6.1.0 - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@2c8a9bd...55cc834) --- updated-dependencies: - dependency-name: actions/cache dependency-version: 6.1.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github_actions ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* refactor: replace narrowable mixed PHPDocs with specific types * refactor: collapse long form `mixed` to just `mixed`
* fix: validate forwarded HTTPS headers against trusted proxies * apply note about dual-stack servers * apply method visibility change
Co-authored-by: Bogdan <matolq@gmail.com>
Co-authored-by: Bogdan <matolq@gmail.com>
…ength tracking (#10344) * refactor: optimize prepQuotedPrintable() with O(1) lookup, int-length tracking, and sprintf encoding * cs-fix
* fix: satisfy PHPStan 2.2.3 - Remove redundant output-buffer level checks after ob_start() - Narrow output-buffer helper return types Signed-off-by: memleakd <121398829+memleakd@users.noreply.github.com> * fix: handle command output buffer changes Signed-off-by: memleakd <121398829+memleakd@users.noreply.github.com> --------- Signed-off-by: memleakd <121398829+memleakd@users.noreply.github.com>
Updates the requirements on [boundwize/structarmed](https://github.com/boundwize/structarmed) to permit the latest version. Updates `boundwize/structarmed` to 0.14.7 - [Release notes](https://github.com/boundwize/structarmed/releases) - [Commits](boundwize/structarmed@0.14.6...0.14.7) --- updated-dependencies: - dependency-name: boundwize/structarmed dependency-version: 0.14.7 dependency-type: direct:development dependency-group: composer-dependencies ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Updates the requirements on [boundwize/structarmed](https://github.com/boundwize/structarmed) to permit the latest version. Updates `boundwize/structarmed` to 0.14.9 - [Release notes](https://github.com/boundwize/structarmed/releases) - [Commits](boundwize/structarmed@0.14.7...0.14.9) --- updated-dependencies: - dependency-name: boundwize/structarmed dependency-version: 0.14.9 dependency-type: direct:development dependency-group: composer-dependencies ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Updates the requirements on [boundwize/structarmed](https://github.com/boundwize/structarmed) to permit the latest version. Updates `boundwize/structarmed` to 0.14.10 - [Release notes](https://github.com/boundwize/structarmed/releases) - [Commits](boundwize/structarmed@0.14.9...0.14.10) --- updated-dependencies: - dependency-name: boundwize/structarmed dependency-version: 0.14.10 dependency-type: direct:development dependency-group: composer-dependencies ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* chore: Bump Rector to 2.5.3 and re-run it * chore: apply cs fix
…ns and loop invariants (#10351) * perf: optimize _processForeignKeys() Refactors _processForeignKeys() to: - calculate invariant SQL fragments outside the loop - cache escaped table identifier - build SQL string locally before concatenating to the array, saving intermediate string allocations * refactor: apply code review fixes for _processForeignKeys optimization - Restore fast return without foreign keys\n- Remove unrelated formatting changes\n- Remove non-English comment
* fix: support array indexes in getPostGet() and getGetPost() * fix phpstan
Updates the requirements on [rector/rector](https://github.com/rectorphp/rector) to permit the latest version. Updates `rector/rector` to 2.5.4 - [Release notes](https://github.com/rectorphp/rector/releases) - [Commits](rectorphp/rector@2.5.3...2.5.4) --- updated-dependencies: - dependency-name: rector/rector dependency-version: 2.5.4 dependency-type: direct:development dependency-group: composer-dependencies ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
michalsn
approved these changes
Jul 7, 2026
samsonasik
approved these changes
Jul 7, 2026
| @@ -87,67 +87,7 @@ public function getIPAddress(): string | |||
|
|
|||
| // @TODO Extract all this IP address logic to another class. | |||
There was a problem hiding this comment.
AS this Functions take of IP Related logic is it good to remove this TODO Comment or is that still something that is needed to be don in future,
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.