chore: Move phpstan.dist.neon order in rector.php config to avoid tmp/schema.php created on run - #10523
Merged
Conversation
…/schema.php created on run
Member
Author
|
Ready to review/merge 👍 |
paulbalandan
approved these changes
Sep 5, 2026
paulbalandan
left a comment
Member
There was a problem hiding this comment.
Oh, this is what I'm asking a while back, which causes rector to create tmp/schema.php. If this fixes it, then all good.
However, in the long term, instead of order dependence I think the better solution is that rector merges configurations with phpstan.dist.neon as the final overrider.
Member
Author
|
Yeah, this is the solution I can found for now. Thank you @paulbalandan for the review, let's merge 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When I run:
It cause
tmp/schema.phpcreated. It seems due tophpstan.dist.neonis loaded early. This PR move it to the last and it seems fix it.Checklist: