Skip to content

chore: Move phpstan.dist.neon order in rector.php config to avoid tmp/schema.php created on run - #10523

Merged
samsonasik merged 1 commit into
codeigniter4:developfrom
samsonasik:chore-phpstan-order
Sep 5, 2026
Merged

chore: Move phpstan.dist.neon order in rector.php config to avoid tmp/schema.php created on run#10523
samsonasik merged 1 commit into
codeigniter4:developfrom
samsonasik:chore-phpstan-order

Conversation

@samsonasik

Copy link
Copy Markdown
Member

Description

When I run:

vendor/bin/rector

It cause tmp/schema.php created. It seems due to phpstan.dist.neon is loaded early. This PR move it to the last and it seems fix it.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value (without duplication)
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@samsonasik

Copy link
Copy Markdown
Member Author

Ready to review/merge 👍

@paulbalandan paulbalandan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, this is what I'm asking a while back, which causes rector to create tmp/schema.php. If this fixes it, then all good.

However, in the long term, instead of order dependence I think the better solution is that rector merges configurations with phpstan.dist.neon as the final overrider.

@samsonasik

Copy link
Copy Markdown
Member Author

Yeah, this is the solution I can found for now.

Thank you @paulbalandan for the review, let's merge 👍

@samsonasik
samsonasik merged commit 745eaa3 into codeigniter4:develop Sep 5, 2026
11 checks passed
@samsonasik
samsonasik deleted the chore-phpstan-order branch September 5, 2026 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants