Fix API repo preparation step#4969
Merged
paulbalandan merged 1 commit intocodeigniter4:developfrom Jul 28, 2021
Merged
Conversation
MGatner
approved these changes
Jul 28, 2021
Member
MGatner
left a comment
There was a problem hiding this comment.
api/docs* will still match api/docs. I'm all for this change but are you sure this was actually the issue?
Member
Author
|
Another issue is the misplaced git reset. If the current rm -rf works, which TIL, the changes are reset by the git command. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The current apidocs workflow is largely based on the
apidocscript. Up until now, there's a typo in the script preventing the removal of the contents of theapi/docsfolder:As you can see, instead of deleting the contents this tries to delete files starting with
api/docswhich doesn't exist. This PR fixes that and makes the output more verbose.Checklist: