Skip to content

Fix API repo preparation step#4969

Merged
paulbalandan merged 1 commit intocodeigniter4:developfrom
paulbalandan:apidocs-action
Jul 28, 2021
Merged

Fix API repo preparation step#4969
paulbalandan merged 1 commit intocodeigniter4:developfrom
paulbalandan:apidocs-action

Conversation

@paulbalandan
Copy link
Copy Markdown
Member

Description
The current apidocs workflow is largely based on the apidoc script. Up until now, there's a typo in the script preventing the removal of the contents of the api/docs folder:

rm -rf api/docs*

As you can see, instead of deleting the contents this tries to delete files starting with api/docs which doesn't exist. This PR fixes that and makes the output more verbose.

Checklist:

  • Securely signed commits

Copy link
Copy Markdown
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

api/docs* will still match api/docs. I'm all for this change but are you sure this was actually the issue?

@paulbalandan
Copy link
Copy Markdown
Member Author

Another issue is the misplaced git reset. If the current rm -rf works, which TIL, the changes are reset by the git command.

@paulbalandan paulbalandan merged commit bd37870 into codeigniter4:develop Jul 28, 2021
@paulbalandan paulbalandan deleted the apidocs-action branch July 28, 2021 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants