Delete docs directly, not api/docs#4976
Merged
paulbalandan merged 1 commit intocodeigniter4:developfrom Jul 28, 2021
Merged
Conversation
696ca45 to
e43fee5
Compare
e43fee5 to
3c4c9a6
Compare
element-code
pushed a commit
to element-code/CodeIgniter4
that referenced
this pull request
Aug 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Apparently, #4969 only fixed half of the problem (which is the
git reset). However, the actual contents ofapi/docsare not removed really. Analysing the logs from the verbosermandmkdir, it shows that:This means that instead of deleting the contents of
docsin the rootapi, it instead looks atapi/docsat the rootapi, a problem of relative paths. This attempts to fix the issue completely.Successful run (in pull request context):
https://github.com/codeigniter4/CodeIgniter4/actions/runs/1075571421
Checklist: