Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
278 commits
Select commit Hold shift + click to select a range
515152b
docs: add explanation
kenjis Aug 21, 2022
a12b231
docs: remove @TODO
kenjis Aug 21, 2022
0314614
Adds a when() method to DB Basebuilder.
lonnieezell Aug 2, 2022
7c81e3e
Add breaking change text back into 4.2.2 changelog that was accidenta…
lonnieezell Aug 21, 2022
ec79d03
code style fix run
lonnieezell Aug 21, 2022
01de988
fix: command usages
kenjis Aug 21, 2022
b064a47
Merge pull request #6399 from kenjis/fix-ComposerJsonTest
kenjis Aug 21, 2022
1fc65c2
Merge pull request #6398 from naente/develop
MGatner Aug 21, 2022
ec98fc9
test: update test
kenjis Aug 21, 2022
aed7114
Merge pull request #6402 from kenjis/fix-command-usage
samsonasik Aug 21, 2022
e48296e
Exclude non-monolithic files from CS
paulbalandan Aug 21, 2022
a791973
fix: SecurityException implements HTTPExceptionInterface
kenjis Aug 21, 2022
d6ecb56
test: update CSRFTest
kenjis Aug 22, 2022
4727025
Merge pull request #6390 from iRedds/fix/alias-subquery
kenjis Aug 22, 2022
66af822
Update system/Database/SQLite3/Table.php
sclubricants Aug 22, 2022
7d7d967
Merge pull request #6384 from kenjis/feat-validation-errors
kenjis Aug 22, 2022
b2f23cb
docs: fix doc comment sytle
kenjis Aug 20, 2022
6bff1fa
docs: make types more accurate
kenjis Aug 20, 2022
68a9a8f
feat: add Autoloader::unregister() for testing
kenjis Aug 20, 2022
413facc
test: unregister autoloaders that are registered in testing
kenjis Aug 20, 2022
1e945cb
feat: add $helpers to Config\Autoload
kenjis Aug 20, 2022
6f8cace
test: refactor tests
kenjis Aug 20, 2022
84da1d5
docs: remove '```' in doc comments
kenjis Aug 21, 2022
b4b9829
refactor: autoload URL helper in Autoloader
kenjis Aug 21, 2022
4e127c9
docs: add docs
kenjis Aug 21, 2022
9710f67
refactor: run rector
kenjis Aug 21, 2022
4e3e20c
test: add @runInSeparateProcess
kenjis Aug 22, 2022
4375928
config: change Securiry::$redirect to false
kenjis Aug 21, 2022
7231498
config: update env
kenjis Aug 21, 2022
80eb987
docs : fix typo in "General Topics » Managing your Applications"
cijagani Aug 22, 2022
40c69f0
Merge pull request #6411 from cijagani/develop
samsonasik Aug 22, 2022
512f253
fix: cs-fix
ping-yee Aug 22, 2022
071cd04
Merge pull request #6378 from ping-yee/fix-validation-custom-error-as…
kenjis Aug 22, 2022
e035c1f
Merge pull request #6397 from kenjis/feat-autoload-helpers
kenjis Aug 22, 2022
55bb2e5
docs: fix typo
kenjis Aug 22, 2022
ec6e6a9
Merge pull request #6408 from kenjis/fix-SecurityException-HTTP-status
kenjis Aug 22, 2022
5ad816b
Merge remote-tracking branch 'upstream/develop' into 4.3
kenjis Aug 22, 2022
bece503
Add RawSql to BaseConnection->escape()
sclubricants Aug 2, 2022
baa49b3
Move user guide and move test to live
sclubricants Aug 3, 2022
447e655
Fixes
sclubricants Aug 4, 2022
d0023b1
remove documentation and add notes
sclubricants Aug 5, 2022
dc76fea
fix objectToArray()
sclubricants Aug 5, 2022
accdfee
Update BaseBuilder.php
sclubricants Aug 5, 2022
c6e7bd3
Create RawSqlTest.php
sclubricants Aug 8, 2022
d218e86
fix sql
sclubricants Aug 8, 2022
87af5f8
Fix logic
sclubricants Aug 19, 2022
ad3e088
fix is_a to instanceof
sclubricants Aug 19, 2022
9546098
Merge pull request #6401 from paulbalandan/cs-exclude
paulbalandan Aug 23, 2022
1760b09
docs: update about test database
kenjis Aug 23, 2022
7100bc6
docs: update test database config sample in .env
kenjis Aug 23, 2022
fa474ad
config: change commented database.tests.database value
kenjis Aug 23, 2022
0fc684e
docs: restore phpunit.xml
kenjis Aug 23, 2022
f11edae
add testInsertObjectWithRawSql()
sclubricants Aug 23, 2022
b2ad447
Add testDropColumnDropCompositeKey()
sclubricants Aug 23, 2022
7717097
Fix test
sclubricants Aug 23, 2022
9a4ee1b
fix
sclubricants Aug 23, 2022
3bcc652
Merge pull request #6417 from kenjis/fix-docs-test-database
kenjis Aug 24, 2022
70d27e0
docs: fix by proofreading
kenjis Aug 24, 2022
39d1162
docs: add Backward Compatibility Notes
kenjis Aug 24, 2022
fb042fc
[Rector] Clean up skip UnwrapFutureCompatibleIfPhpVersionRector
samsonasik Aug 24, 2022
31c9296
run rector.php
samsonasik Aug 24, 2022
8ffd54d
run rector.php
samsonasik Aug 24, 2022
9e1b87a
Merge pull request #6420 from samsonasik/rector-cleanup
samsonasik Aug 24, 2022
86f0746
Merge pull request #6418 from kenjis/docs-backward_compatibility_notes
kenjis Aug 25, 2022
c3aa797
Merge pull request #6416 from kenjis/fix-tests-README
kenjis Aug 25, 2022
b0da9eb
Merge pull request #6396 from sclubricants/SqliteTable
kenjis Aug 25, 2022
7acd0fe
docs: fix git command example
kenjis Aug 25, 2022
6344fc7
Merge pull request #6332 from sclubricants/DbEscape
kenjis Aug 25, 2022
94de4bd
Merge remote-tracking branch 'upstream/develop' into 4.3
kenjis Aug 25, 2022
f92de2c
Merge pull request #6422 from kenjis/fix-contributing/workflow.md
kenjis Aug 25, 2022
44524ee
Merge pull request #6406 from kenjis/fix-csrf-redirect-default
kenjis Aug 25, 2022
45025a1
Merge pull request #6400 from kenjis/refactor-ForgeTest-getFieldData
kenjis Aug 26, 2022
2f244e3
docs: replace mixed in Database doc comments
kenjis Aug 26, 2022
0454d73
docs: update the reference to Time, and make it a note
kenjis Aug 26, 2022
f9f606d
docs: fix text decoration
kenjis Aug 26, 2022
90dda25
docs: Correct the explanation of now()
kenjis Aug 26, 2022
1e0ea34
refactor: remove unused key '_parent_name'
kenjis Aug 26, 2022
6234f0e
Merge pull request #6427 from kenjis/remove-_parent_name
samsonasik Aug 26, 2022
d67a587
Fix Field Length For Text
sclubricants Aug 21, 2022
fcb1ab3
add SQLSRV as well
sclubricants Aug 21, 2022
79c9f95
Add Test and SQLSRV fix
sclubricants Aug 21, 2022
9022215
fix
sclubricants Aug 21, 2022
416cc65
fix cache issue
sclubricants Aug 22, 2022
27ba993
Fix escape and add changelog
sclubricants Aug 26, 2022
c9002e5
Merge remote-tracking branch 'upstream/develop' into 4.3
kenjis Aug 27, 2022
96a3341
feat: add Time::toDatabase()
kenjis Aug 27, 2022
c8b9397
docs: make @return more accurate
kenjis Aug 27, 2022
b53d482
fix: remove harmful @mixin in RequestInterface
kenjis Aug 24, 2022
dff94db
fix: add missing get*() methods in CLIRequest
kenjis Aug 24, 2022
873f616
fix: Honeypot filter causes error
kenjis Aug 24, 2022
8c37dd1
test: update NegotiateTest
kenjis Aug 25, 2022
42ac32d
test: remove unneeded tearDown()
kenjis Aug 25, 2022
5d7f529
fix: return type of added get*() methods
kenjis Aug 27, 2022
b8e0e64
docs: add explanation about a shared instance and parameters
kenjis Aug 27, 2022
210b60f
docs: add @method groupBy() in Model
kenjis Aug 27, 2022
f46d24b
Merge pull request #6433 from kenjis/fix-Model-doc-comment
kenjis Aug 27, 2022
64b6684
docs: add user guide
kenjis Aug 27, 2022
f160747
Merge pull request #6432 from kenjis/fix-docs-services.rst
kenjis Aug 27, 2022
0d90f84
Merge pull request #6424 from kenjis/remove-mixed-in-db
kenjis Aug 27, 2022
e686a14
Merge pull request #6421 from kenjis/fix-RequestInterface-mixin
kenjis Aug 27, 2022
1621263
docs: fix by proofreading
kenjis Aug 27, 2022
7cc7283
Remove unneeded abstract `handle()` method
paulbalandan Aug 27, 2022
799d655
Merge pull request #6426 from kenjis/fix-docs-date_helper
kenjis Aug 27, 2022
7ec384b
chore: update Kint to 4.2.0
kenjis Aug 27, 2022
97605f4
docs: add changelog
kenjis Aug 27, 2022
e215d66
docs: remove description on squashing commits
kenjis Aug 28, 2022
122133b
docs: add explanation on commits and commit messages
kenjis Aug 28, 2022
55fd7f0
docs: update wording
kenjis Aug 28, 2022
2e95625
docs: move description from signing to workflow
kenjis Aug 28, 2022
c382096
docs: add link to detailed explanation
kenjis Aug 28, 2022
622f829
Merge pull request #6434 from codeigniter4/paulbalandan-patch-1
paulbalandan Aug 28, 2022
596e443
Merge pull request #6431 from kenjis/feat-Time-toDatabase
kenjis Aug 28, 2022
596b629
chore: update kint vertion to ^4.2
kenjis Aug 28, 2022
53e1483
docs: $db->getFieldData() data explanation is not complete
naente Aug 28, 2022
a65e57a
Merge pull request #6437 from kenjis/add-docs-on-PR-commits
kenjis Aug 28, 2022
6a31be4
Merge pull request #6436 from kenjis/update-kint-to-420
kenjis Aug 28, 2022
b6d9f91
docs: fix incorrect links to the spark page
kenjis Aug 28, 2022
199a4cb
Merge remote-tracking branch 'upstream/develop' into 4.3
kenjis Aug 28, 2022
5e7b4fe
test: fix incorrect assertions
kenjis Aug 28, 2022
6aafff0
fix: add missing CLIRequest::getLocale()
kenjis Aug 28, 2022
31aab61
Merge pull request #6442 from kenjis/fix-CLIRequest-getLocale-error
MGatner Aug 29, 2022
d800a75
Merge pull request #6441 from kenjis/fix-docs-link-to-spark
MGatner Aug 29, 2022
cd450e7
Prep for 4.2.5 release
MGatner Aug 29, 2022
bd51e98
Add Psalm
MGatner Aug 29, 2022
800c2c1
Merge pull request #6443 from codeigniter4/release-4.2.5
MGatner Aug 29, 2022
d51d4e9
Merge pull request #6445 from codeigniter4/develop
MGatner Aug 29, 2022
43cca38
Merge branch 'develop' into 4.3
MGatner Aug 29, 2022
2e3dd46
chore: add `rector process --dry-run` to `composer analyze`
kenjis Aug 29, 2022
cb60d93
chore: add composer script aliaes
kenjis Aug 29, 2022
a589af0
docs: update pull_request.md
kenjis Aug 29, 2022
14bfd1f
docs: add Changing a commit message
kenjis Aug 29, 2022
71a4bed
docs: change letter cases in titles
kenjis Aug 29, 2022
f6c254a
feat: you can set locale manually to route_to()
kenjis Aug 29, 2022
eeca1fe
docs: add user guide
kenjis Aug 25, 2022
b13007c
refactor: initialize Kint only when CI_DEBUG is true
kenjis Aug 29, 2022
144f6b8
chore: move kint-php/kint to require-dev
kenjis Aug 29, 2022
bfb4c2e
refactor: extract methods
kenjis Aug 29, 2022
b748076
chore: update framework/composer.json
kenjis Aug 29, 2022
defbeda
Changed StreamFilterTrait and CITestStreamFilter.
iRedds Aug 29, 2022
98ebbae
missing example
iRedds Aug 29, 2022
78caf41
fix example
iRedds Aug 29, 2022
2788a49
Merge pull request #6440 from naente/develop
MGatner Aug 29, 2022
2dd3562
refactor: vendor/bin/rector process
kenjis Aug 29, 2022
0488516
Update psalm.xml
MGatner Aug 29, 2022
bae9665
Merge pull request #6446 from kenjis/update-composer-scripts
kenjis Aug 29, 2022
f1862a0
Merge pull request #6447 from kenjis/update-contributing/workflow.md
kenjis Aug 29, 2022
536e5b1
docs: add about controllers namespace in routing
kenjis Aug 29, 2022
a8c69e8
- FIX: in command prompt
daycry Aug 29, 2022
27c8817
Merge branch '4.3' into PostgreTextLength
sclubricants Aug 30, 2022
ba25d8f
Changelog CITestStreamFilter
iRedds Aug 30, 2022
b298bc5
Merge pull request #6448 from kenjis/feat-route_to-locale-param
kenjis Aug 30, 2022
0fbecce
Merge pull request #6405 from sclubricants/PostgreTextLength
kenjis Aug 30, 2022
2fb6a1d
Upgrade guide
iRedds Aug 30, 2022
8e6bff9
Merge pull request #6450 from iRedds/fix/tests-streams
kenjis Aug 30, 2022
8e1e695
Update FileRules.php
daycry Aug 30, 2022
9e34a8f
Update FileRules.php
daycry Aug 30, 2022
426873f
Update FileRules.php
daycry Aug 30, 2022
cd4bc83
Merge pull request #6452 from daycry/patch-1
MGatner Aug 30, 2022
e046890
docs: improve sample code
kenjis Aug 30, 2022
a51b07c
Merge pull request #6451 from kenjis/fix-docs-routing-namespace
kenjis Aug 30, 2022
d955f83
docs: add a new section title
kenjis Aug 30, 2022
962a0c0
docs: add note for validation
kenjis Aug 30, 2022
9010060
docs: update RST format
kenjis Aug 30, 2022
1aeb5b3
test: restore changed locale in tearDown()
kenjis Aug 31, 2022
69c407b
docs: update PHPDoc in Entity
kenjis Aug 31, 2022
528eed7
test: fix invalid locale value
kenjis Aug 31, 2022
5b396db
Merge pull request #6462 from kenjis/fix-Entity-phpdoc
kenjis Aug 31, 2022
57385ea
Merge pull request #6460 from kenjis/fix-test-restore-locales
kenjis Aug 31, 2022
a6e4d38
Merge pull request #6449 from kenjis/move-kint-to-require-dev
kenjis Aug 31, 2022
59614de
Merge pull request #6444 from MGatner/psalm-config
MGatner Sep 1, 2022
7bdecb5
Merge remote-tracking branch 'upstream/develop' into 4.3
kenjis Sep 1, 2022
acf6b5d
docs: categorize Enhancements
kenjis Sep 1, 2022
f90b5c7
docs: add sub sections for methods
kenjis Sep 1, 2022
42f264a
docs: add links to detailed pages
kenjis Sep 1, 2022
68fff4a
docs: move "autoload helpers" from "Others" to "Helpers and Functions"
kenjis Sep 1, 2022
f957100
chore: remove ignore error patterns
kenjis Sep 2, 2022
1479d28
refactor: fix PHPStan error
kenjis Sep 2, 2022
0c01f8b
Merge pull request #6469 from kenjis/fix-docs-changelogs/v4.3.0.rst
kenjis Sep 2, 2022
3ba1eb5
Merge pull request #6470 from kenjis/fix-phpstan-errors
kenjis Sep 2, 2022
428057a
Merge remote-tracking branch 'upstream/develop' into 4.3
kenjis Sep 2, 2022
f94fb2b
Fix fatal error gets turned to `0` severity on shutdown handler
paulbalandan Sep 2, 2022
698928a
Fix redis cache increment/decrement methods
paulbalandan Sep 2, 2022
6815794
docs: add @deprecated
kenjis Aug 31, 2022
1fe22d1
docs: fix namespace
kenjis Aug 31, 2022
97d1a51
docs: add deprecation of Cookie::withNeverExpiring()
kenjis Aug 31, 2022
dcd4ab9
docs: remove `@inheritDoc`
kenjis Sep 2, 2022
8760a49
fix: JSON data may cause "Array to string conversion" error
kenjis Sep 1, 2022
0a00fad
New fork from 4.3 branch.
tangix Sep 2, 2022
c9438c9
Added note to Change Log
tangix Sep 2, 2022
4c48b59
Fix broken caching system when array of allowed parameters used
JavaDeveloperKiev Sep 2, 2022
2b5dae8
Create test for Cache Query String options
JavaDeveloperKiev Sep 2, 2022
f58db31
docs: fix incorrect explanation
kenjis Sep 2, 2022
3eb0ea4
Merge pull request #6463 from kenjis/deprecate-Cookie-withNeverExpiring
kenjis Sep 2, 2022
62c5d80
Merge pull request #6467 from kenjis/fix-validation-json-data
kenjis Sep 2, 2022
e2606a8
Merge pull request #6472 from paulbalandan/shutdown-handler
kenjis Sep 2, 2022
924b3c4
Merge pull request #6473 from paulbalandan/redis-incr
kenjis Sep 2, 2022
be32309
docs: add missing period
kenjis Sep 2, 2022
7c610bf
Merge remote-tracking branch 'upstream/develop' into 4.3
kenjis Sep 2, 2022
465422a
docs: add about composer.json autoload.psr-4
kenjis Sep 2, 2022
24e16a1
Merge pull request #6474 from tangix/fix-lang-consistency-2
kenjis Sep 2, 2022
9cbe0a2
Merge pull request #6476 from kenjis/fix-docs-upgrade_420.rst
kenjis Sep 3, 2022
846a5ac
Bump php-cs-fixer to ~3.11.0
paulbalandan Sep 2, 2022
ec2dc1b
Remove deprecated `Nexus/space_after_comment_start`
paulbalandan Sep 2, 2022
eb44074
Apply formatting fixes
paulbalandan Sep 2, 2022
b57909f
Simplify coverage comment
paulbalandan Sep 2, 2022
4369d20
Configure `groups` option of `phpdoc_separation`
paulbalandan Sep 3, 2022
7b2ad9c
Merge pull request #6471 from paulbalandan/cs-fixer
paulbalandan Sep 3, 2022
997be6d
chore(deps-dev): update rector/rector requirement from 0.14.0 to 0.14.1
dependabot[bot] Sep 3, 2022
e0515a8
Enable `blank_line_between_import_groups`
paulbalandan Sep 3, 2022
5d3bd72
re-run rector
samsonasik Sep 3, 2022
51e67a7
Merge pull request #6477 from codeigniter4/dependabot/composer/rector…
samsonasik Sep 3, 2022
a8072a5
Merge pull request #6475 from JavaDeveloperKiev/cachingBugFix
kenjis Sep 4, 2022
dbd1bac
Merge pull request #6459 from kenjis/fix-docs-model-validation
kenjis Sep 4, 2022
e874fe6
Merge pull request #6478 from paulbalandan/blank-line-between-import-…
MGatner Sep 4, 2022
879c30f
Fix overlooked coding style violations
paulbalandan Sep 4, 2022
265e7a8
Merge pull request #6491 from paulbalandan/style-fix
paulbalandan Sep 4, 2022
50dc13d
Enable `control_structure_braces`
paulbalandan Sep 3, 2022
c261861
Merge pull request #6479 from paulbalandan/control-structure-braces
paulbalandan Sep 4, 2022
a7b7422
test: refactor StrictRules/RulesTest
kenjis Sep 4, 2022
41094eb
test: remove duplicate test data
kenjis Sep 4, 2022
bc06c08
fix: TypeError in greater_than_equal_to
kenjis Sep 4, 2022
381a445
fix: TypeError in greater_than
kenjis Sep 4, 2022
a7c42cd
fix: TypeError in less_than and less_than_equal_to
kenjis Sep 4, 2022
a275427
Enable `no_multiple_statements_per_line`
paulbalandan Sep 3, 2022
65398c3
Merge pull request #6481 from paulbalandan/no_multiple_statements_per…
paulbalandan Sep 4, 2022
70c3f14
Enable `no_useless_nullsafe_operator`
paulbalandan Sep 3, 2022
681b13d
Merge pull request #6483 from paulbalandan/no-useless-nullsafe-operator
paulbalandan Sep 4, 2022
b0f7938
Enable `statement_indentation`
paulbalandan Sep 3, 2022
96b4198
Merge pull request #6485 from paulbalandan/statement-indentation
paulbalandan Sep 4, 2022
f768d16
fix: TypeError when the value is not int or string
kenjis Sep 4, 2022
7c13249
Add `inline_constructor_arguments` option to `class_definition`
paulbalandan Sep 3, 2022
836a5aa
Merge pull request #6486 from paulbalandan/class-definition
paulbalandan Sep 4, 2022
7a32c6d
Enable `no_trailing_comma_in_singleline`
paulbalandan Sep 3, 2022
2a0c62f
Enable `single_line_comment_spacing`
paulbalandan Sep 3, 2022
5a182de
Remove commented-out code
paulbalandan Sep 3, 2022
3be80cb
Merge pull request #6492 from kenjis/fix-validation-greater_than_equa…
kenjis Sep 4, 2022
780f2e0
Merge pull request #6482 from paulbalandan/no-trailing-comma-in-singl…
MGatner Sep 4, 2022
a5154bf
Merge pull request #6484 from paulbalandan/single_line_comment_spacing
MGatner Sep 4, 2022
4fa83f7
Prep for 4.2.6 release
MGatner Sep 4, 2022
d1a9d04
Merge pull request #6494 from codeigniter4/release-4.2.6
MGatner Sep 4, 2022
265ed2f
Merge pull request #6495 from codeigniter4/develop
MGatner Sep 4, 2022
c9eb3d5
Merge branch 'develop' into 4.3
MGatner Sep 4, 2022
b2d5f79
style: composer cs-fix
kenjis Sep 5, 2022
b411094
Merge pull request #6501 from kenjis/fix-cs
kenjis Sep 6, 2022
042fd2e
Adds a when() method to DB Basebuilder.
lonnieezell Aug 2, 2022
b001465
Add breaking change text back into 4.2.2 changelog that was accidenta…
lonnieezell Aug 21, 2022
47f06d6
code style fix run
lonnieezell Aug 21, 2022
4a62537
Addressing review comments
lonnieezell Sep 6, 2022
be62d6a
Merge branch 'db-when' of github.com:codeigniter4/CodeIgniter4 into d…
lonnieezell Sep 6, 2022
9c5b254
Update tests/system/Database/Builder/WhenTest.php
lonnieezell Sep 6, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/test-rector.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ on:
- 'utils/**.php'
- '.github/workflows/test-rector.yml'
- composer.json
- rector.php

push:
branches:
Expand All @@ -26,6 +27,7 @@ on:
- 'utils/**.php'
- '.github/workflows/test-rector.yml'
- composer.json
- rector.php

jobs:
build:
Expand Down
47 changes: 43 additions & 4 deletions .php-cs-fixer.dist.php
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
use CodeIgniter\CodingStandard\CodeIgniter4;
use Nexus\CsConfig\Factory;
use Nexus\CsConfig\Fixer\Comment\NoCodeSeparatorCommentFixer;
use Nexus\CsConfig\Fixer\Comment\SpaceAfterCommentStartFixer;
use Nexus\CsConfig\FixerGenerator;
use PhpCsFixer\Finder;

Expand All @@ -25,7 +24,11 @@
__DIR__ . '/tests',
__DIR__ . '/utils',
])
->exclude(['ThirdParty'])
->exclude([
'Pager/Views',
'ThirdParty',
'Validation/Views',
])
->notName('#Foobar.php$#')
->append([
__FILE__,
Expand All @@ -35,15 +38,51 @@
__DIR__ . '/spark',
]);

$overrides = [];
$overrides = [
// <<<<<<<<<<<<<<<<<<<<<<<< @TODO TO BE REMOVED ONCE LIVE IN CODING-STANDARD
'blank_line_between_import_groups' => true,
'class_definition' => [
'multi_line_extends_each_single_line' => true,
'single_item_single_line' => true,
'single_line' => true,
'space_before_parenthesis' => true,
'inline_constructor_arguments' => true,
],
'control_structure_braces' => true,
'no_multiple_statements_per_line' => true,
'no_trailing_comma_in_singleline' => [
'elements' => [
'arguments',
'array_destructuring',
'array',
'group_import',
],
],
'no_useless_nullsafe_operator' => true,
'phpdoc_separation' => [
'groups' => [
['immutable', 'psalm-immutable'],
['param', 'phpstan-param', 'psalm-param'],
['phpstan-pure', 'psalm-pure'],
['readonly', 'psalm-readonly'],
['return', 'phpstan-return', 'psalm-return'],
['template', 'phpstan-template', 'psalm-template'],
['template-covariant', 'phpstan-template-covariant', 'psalm-template-covariant'],
['phpstan-type', 'psalm-type'],
['var', 'phpstan-var', 'psalm-var'],
],
],
'single_line_comment_spacing' => true,
'statement_indentation' => true,
// >>>>>>>>>>>>>>>>>>>>>>>>>
];

$options = [
'cacheFile' => 'build/.php-cs-fixer.cache',
'finder' => $finder,
'customFixers' => FixerGenerator::create('vendor/nexusphp/cs-config/src/Fixer', 'Nexus\\CsConfig\\Fixer'),
'customRules' => [
NoCodeSeparatorCommentFixer::name() => true,
SpaceAfterCommentStartFixer::name() => true,
],
];

Expand Down
42 changes: 39 additions & 3 deletions .php-cs-fixer.no-header.php
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
use CodeIgniter\CodingStandard\CodeIgniter4;
use Nexus\CsConfig\Factory;
use Nexus\CsConfig\Fixer\Comment\NoCodeSeparatorCommentFixer;
use Nexus\CsConfig\Fixer\Comment\SpaceAfterCommentStartFixer;
use Nexus\CsConfig\FixerGenerator;
use PhpCsFixer\Finder;

Expand All @@ -25,20 +24,57 @@
__DIR__ . '/app',
__DIR__ . '/public',
])
->exclude(['Views/errors/html'])
->notName('#Logger\.php$#')
->append([
__DIR__ . '/admin/starter/builds',
]);

$overrides = [];
$overrides = [
// <<<<<<<<<<<<<<<<<<<<<<<< @TODO TO BE REMOVED ONCE LIVE IN CODING-STANDARD
'blank_line_between_import_groups' => true,
'class_definition' => [
'multi_line_extends_each_single_line' => true,
'single_item_single_line' => true,
'single_line' => true,
'space_before_parenthesis' => true,
'inline_constructor_arguments' => true,
],
'control_structure_braces' => true,
'no_multiple_statements_per_line' => true,
'no_trailing_comma_in_singleline' => [
'elements' => [
'arguments',
'array_destructuring',
'array',
'group_import',
],
],
'no_useless_nullsafe_operator' => true,
'phpdoc_separation' => [
'groups' => [
['immutable', 'psalm-immutable'],
['param', 'phpstan-param', 'psalm-param'],
['phpstan-pure', 'psalm-pure'],
['readonly', 'psalm-readonly'],
['return', 'phpstan-return', 'psalm-return'],
['template', 'phpstan-template', 'psalm-template'],
['template-covariant', 'phpstan-template-covariant', 'psalm-template-covariant'],
['phpstan-type', 'psalm-type'],
['var', 'phpstan-var', 'psalm-var'],
],
],
'single_line_comment_spacing' => true,
'statement_indentation' => true,
// >>>>>>>>>>>>>>>>>>>>>>>>>
];

$options = [
'cacheFile' => 'build/.php-cs-fixer.no-header.cache',
'finder' => $finder,
'customFixers' => FixerGenerator::create('vendor/nexusphp/cs-config/src/Fixer', 'Nexus\\CsConfig\\Fixer'),
'customRules' => [
NoCodeSeparatorCommentFixer::name() => true,
SpaceAfterCommentStartFixer::name() => true,
],
];

Expand Down
38 changes: 36 additions & 2 deletions .php-cs-fixer.user-guide.php
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
use CodeIgniter\CodingStandard\CodeIgniter4;
use Nexus\CsConfig\Factory;
use Nexus\CsConfig\Fixer\Comment\NoCodeSeparatorCommentFixer;
use Nexus\CsConfig\Fixer\Comment\SpaceAfterCommentStartFixer;
use Nexus\CsConfig\FixerGenerator;
use PhpCsFixer\Finder;

Expand All @@ -34,6 +33,42 @@
'php_unit_internal_class' => false,
'no_unused_imports' => false,
'class_attributes_separation' => false,
// <<<<<<<<<<<<<<<<<<<<<<<< @TODO TO BE REMOVED ONCE LIVE IN CODING-STANDARD
'blank_line_between_import_groups' => true,
'class_definition' => [
'multi_line_extends_each_single_line' => true,
'single_item_single_line' => true,
'single_line' => true,
'space_before_parenthesis' => true,
'inline_constructor_arguments' => true,
],
'control_structure_braces' => true,
'no_multiple_statements_per_line' => true,
'no_trailing_comma_in_singleline' => [
'elements' => [
'arguments',
'array_destructuring',
'array',
'group_import',
],
],
'no_useless_nullsafe_operator' => true,
'phpdoc_separation' => [
'groups' => [
['immutable', 'psalm-immutable'],
['param', 'phpstan-param', 'psalm-param'],
['phpstan-pure', 'psalm-pure'],
['readonly', 'psalm-readonly'],
['return', 'phpstan-return', 'psalm-return'],
['template', 'phpstan-template', 'psalm-template'],
['template-covariant', 'phpstan-template-covariant', 'psalm-template-covariant'],
['phpstan-type', 'psalm-type'],
['var', 'phpstan-var', 'psalm-var'],
],
],
'single_line_comment_spacing' => true,
'statement_indentation' => true,
// >>>>>>>>>>>>>>>>>>>>>>>>>
];

$options = [
Expand All @@ -42,7 +77,6 @@
'customFixers' => FixerGenerator::create('vendor/nexusphp/cs-config/src/Fixer', 'Nexus\\CsConfig\\Fixer'),
'customRules' => [
NoCodeSeparatorCommentFixer::name() => true,
SpaceAfterCommentStartFixer::name() => true,
],
];

Expand Down
42 changes: 42 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,47 @@
# Changelog

## [v4.2.6](https://github.com/codeigniter4/CodeIgniter4/tree/v4.2.6) (2022-09-04)
[Full Changelog](https://github.com/codeigniter4/CodeIgniter4/compare/v4.2.5...v4.2.6)

### Fixed Bugs
* fix: AssertionError occurs when using Validation in CLI by @daycry in https://github.com/codeigniter4/CodeIgniter4/pull/6452
* fix: [Validation] JSON data may cause "Array to string conversion" error by @kenjis in https://github.com/codeigniter4/CodeIgniter4/pull/6467
* Fix fatal error gets turned to `0` severity on shutdown handler by @paulbalandan in https://github.com/codeigniter4/CodeIgniter4/pull/6472
* Fix redis cache increment/decrement methods by @paulbalandan in https://github.com/codeigniter4/CodeIgniter4/pull/6473
* Fix broken caching system when array of allowed parameters used by @JavaDeveloperKiev in https://github.com/codeigniter4/CodeIgniter4/pull/6475
* fix: Strict Validation Rules greater_than/less_than by @kenjis in https://github.com/codeigniter4/CodeIgniter4/pull/6492

### Refactoring
* refactor: fix PHPStan errors by @kenjis in https://github.com/codeigniter4/CodeIgniter4/pull/6470
* Bump `friendsofphp/php-cs-fixer` to `~3.11.0` by @paulbalandan in https://github.com/codeigniter4/CodeIgniter4/pull/6471
* Fix overlooked coding style violations by @paulbalandan in https://github.com/codeigniter4/CodeIgniter4/pull/6491

## [v4.2.5](https://github.com/codeigniter4/CodeIgniter4/tree/v4.2.5) (2022-08-28)
[Full Changelog](https://github.com/codeigniter4/CodeIgniter4/compare/v4.2.4...v4.2.5)

### Breaking Changes
* Add $cached param to BaseConnection::tableExists() by @sclubricants in https://github.com/codeigniter4/CodeIgniter4/pull/6364
* Fix validation custom error asterisk field by @ping-yee in https://github.com/codeigniter4/CodeIgniter4/pull/6378

### Fixed Bugs
* fix: Email class may not log an error when it fails to send by @kenjis in https://github.com/codeigniter4/CodeIgniter4/pull/6362
* fix: Response::download() causes TypeError by @kenjis in https://github.com/codeigniter4/CodeIgniter4/pull/6361
* fix: command usages by @kenjis in https://github.com/codeigniter4/CodeIgniter4/pull/6402
* Fix: The subquery adds a prefix for the table alias. by @iRedds in https://github.com/codeigniter4/CodeIgniter4/pull/6390
* Fix Sqlite Table::createTable() by @sclubricants in https://github.com/codeigniter4/CodeIgniter4/pull/6396
* docs: add missing `@method` `groupBy()` in Model by @kenjis in https://github.com/codeigniter4/CodeIgniter4/pull/6433
* fix: CLIRequest Erros in CLI by @kenjis in https://github.com/codeigniter4/CodeIgniter4/pull/6421
* fix: Call to undefined method CodeIgniter\HTTP\CLIRequest::getLocale() by @kenjis in https://github.com/codeigniter4/CodeIgniter4/pull/6442

### Enhancements
* chore: update Kint to 4.2.0 by @kenjis in https://github.com/codeigniter4/CodeIgniter4/pull/6436

### Refactoring
* refactor: add test for DownloadResponse by @kenjis in https://github.com/codeigniter4/CodeIgniter4/pull/6375
* refactor: ValidationTest by @kenjis in https://github.com/codeigniter4/CodeIgniter4/pull/6382
* refactor: remove unused `_parent_name` in BaseBuilder::objectToArray() by @kenjis in https://github.com/codeigniter4/CodeIgniter4/pull/6427
* Remove unneeded abstract `handle()` method by @paulbalandan in https://github.com/codeigniter4/CodeIgniter4/pull/6434

## [v4.2.4](https://github.com/codeigniter4/CodeIgniter4/tree/v4.2.4) (2022-08-13)
[Full Changelog](https://github.com/codeigniter4/CodeIgniter4/compare/v4.2.3...v4.2.4)

Expand Down
17 changes: 14 additions & 3 deletions admin/framework/composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,21 +10,32 @@
"ext-intl": "*",
"ext-json": "*",
"ext-mbstring": "*",
"kint-php/kint": "^4.1.1",
"laminas/laminas-escaper": "^2.9",
"psr/log": "^1.1"
},
"require-dev": {
"kint-php/kint": "^4.2",
"codeigniter/coding-standard": "^1.1",
"fakerphp/faker": "^1.9",
"friendsofphp/php-cs-fixer": "3.6.*",
"friendsofphp/php-cs-fixer": "~3.11.0",
"mikey179/vfsstream": "^1.6",
"nexusphp/cs-config": "^3.3",
"phpunit/phpunit": "^9.1",
"predis/predis": "^1.1 || ^2.0"
},
"suggest": {
"ext-fileinfo": "Improves mime type detection for files"
"ext-imagick": "If you use Image class ImageMagickHandler",
"ext-simplexml": "If you format XML",
"ext-mysqli": "If you use MySQL",
"ext-oci8": "If you use Oracle Database",
"ext-pgsql": "If you use PostgreSQL",
"ext-sqlsrv": "If you use SQL Server",
"ext-sqlite3": "If you use SQLite3",
"ext-memcache": "If you use Cache class MemcachedHandler with Memcache",
"ext-memcached": "If you use Cache class MemcachedHandler with Memcached",
"ext-redis": "If you use Cache class RedisHandler",
"ext-fileinfo": "Improves mime type detection for files",
"ext-readline": "Improves CLI::input() usability"
},
"autoload": {
"psr-4": {
Expand Down
3 changes: 2 additions & 1 deletion app/Config/App.php
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,7 @@ class App extends BaseConfig
*
* @deprecated Use `Config\Security` $redirect property instead of using this property.
*/
public bool $CSRFRedirect = true;
public bool $CSRFRedirect = false;

/**
* --------------------------------------------------------------------------
Expand All @@ -385,6 +385,7 @@ class App extends BaseConfig
* Defaults to `Lax` as recommended in this link:
*
* @see https://portswigger.net/web-security/csrf/samesite-cookies
*
* @deprecated `Config\Cookie` $samesite property is used.
*/
public string $CSRFSameSite = 'Lax';
Expand Down
31 changes: 20 additions & 11 deletions app/Config/Autoload.php
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,10 @@ class Autoload extends AutoloadConfig
* else you will need to modify all of those classes for this to work.
*
* Prototype:
*```
* $psr4 = [
* 'CodeIgniter' => SYSTEMPATH,
* 'App' => APPPATH
* 'App' => APPPATH
* ];
*```
*
* @var array<string, string>
*/
Expand All @@ -56,11 +54,9 @@ class Autoload extends AutoloadConfig
* were being autoloaded through a namespace.
*
* Prototype:
*```
* $classmap = [
* 'MyClass' => '/path/to/class/file.php'
* ];
*```
*
* @var array<string, string>
*/
Expand All @@ -75,13 +71,26 @@ class Autoload extends AutoloadConfig
* or for loading functions.
*
* Prototype:
* ```
* $files = [
* '/path/to/my/file.php',
* ];
* ```
* $files = [
* '/path/to/my/file.php',
* ];
*
* @var array<int, string>
* @var string[]
* @phpstan-var list<string>
*/
public $files = [];

/**
* -------------------------------------------------------------------
* Helpers
* -------------------------------------------------------------------
* Prototype:
* $helpers = [
* 'form',
* ];
*
* @var string[]
* @phpstan-var list<string>
*/
public $helpers = [];
}
Loading