Adds a when() method to the query builder. by lonnieezell · Pull Request #6329 · codeigniter4/CodeIgniter4

lonnieezell · 2022-08-02T05:16:22Z

Description

This adds a method, when() to the Query Builder that can conditionally modify queries based on the truthiness of a given condition.

Checklist:

Securely signed commits
Component(s) with PHPDoc blocks, only if necessary or adds value
Unit testing, with >80% coverage
User guide updated
Conforms to style guide

kenjis · 2022-08-02T05:28:53Z

This is an enhancement, so it should go to 4.3 branch, not develop.

kenjis · 2022-08-03T05:01:42Z

@lonnieezell Only changing the base branch on GitHub will not work.
Because you created the PR branch based on develop.

Even if you rebase, if there are commits that have not been merged into 4.3, the PR branch will contain them.

The easy way is to create a new branch from 4.3 and cherry-pick commits that are needed.

datamweb · 2022-08-03T05:35:41Z

@kenjis , this is a question for me too, if the user has chosen the wrong branch and opens PR. How can he correct it? Please add the necessary explanations to file workflow if possible.

kenjis · 2022-08-03T07:24:26Z

@datamweb
If you have the PR branch feat-abc:

Create a new branch feat-abc-new from the correct branch, and cherry-pick the commits you did.
Delete the PR branch feat-abc, and rename the new branch feat-abc-new to feat-abc.
Force push.
On GitHub PR page, change the base branch to the correct branch.

datamweb · 2022-08-03T07:31:51Z

Great, got it.
Thanks.

kenjis · 2022-08-12T23:09:30Z

@datamweb I sent a PR #6372

Co-authored-by: MGatner <mgatner@icloud.com>

GET/POST data and the Validation Errors are used together when a validation error occurs. Therefore, it is not bad that withInput() also saves the validation errors.

…lly removed

lonnieezell · 2022-08-21T04:34:18Z

@kenjis fixed to point toward 4.3 now

chore: update framework/composer json suggest

kenjis · 2022-08-21T08:18:29Z

- Due to a bug fix, now :php:func:`random_string()` with the first parameter ``'crypto'`` throws ``InvalidArgumentException`` if the second parameter ``$len`` is an odd number.
+- Due to a bug fix, now :php:func:`random_string()` with the first parameter 'crypto' throws InvalidArgumentException if the second parameter $len is an odd number.
+
+Enhancements
+************
+
+none.


Remove this change.

kenjis · 2022-08-21T08:19:19Z

+    /**
+     * Only runs the query when $condition evaluates to true
+     *
+     * @param mixed $condition


Don't use mixed. See #6310

kenjis · 2022-08-21T08:20:44Z

+    /**
+     * @var MockConnection
+     */
+    protected $db;


Use property type, instead of @var.

@kenjis I'm not sure exactly what you're looking for here....

kenjis · 2022-08-21T08:24:41Z

Please add changelog and link to the details page:
https://github.com/codeigniter4/CodeIgniter4/blob/4.3/user_guide_src/source/changelogs/v4.3.0.rst#enhancements

fix: command usages

Add `inline_constructor_arguments` option to `class_definition`

…l_to fix: Strict Validation Rules greater_than/less_than

…e-line Enable `no_trailing_comma_in_singleline`

Enable `single_line_comment_spacing`

Prep for 4.2.6 release

4.2.6 Ready code

[4.3] update coding style

…lly removed

…b-when

Co-authored-by: kenjis <kenji.uui@gmail.com>

lonnieezell · 2022-09-06T04:20:26Z

Well, looks like pulling in the changes from remote screwed me over here. Will fix that tomorrow.

iRedds · 2022-09-15T05:43:20Z

I was sure I left a comment on this PR, but for some reason I didn't find it. I must have gotten too old. =)

I would like to suggest reconsidering the idea of this feature.

The when method is not logically related to databases and can be applied to the framework API.
It seems to me that it would be more convenient to put this method into a separate trait, which can be added to such classes as Request, Response, Model, and other classes.

In addition to the when method, you can also add the whenNot method.

lonnieezell · 2022-09-23T03:53:05Z

The when method is not logically related to databases and can be applied to the framework API.
It seems to me that it would be more convenient to put this method into a separate trait, which can be added to such classes as Request, Response, Model, and other classes.

In addition to the when method, you can also add the whenNot method.

@iRedds I think that's a great idea. Will do.

lonnieezell · 2022-09-23T04:55:20Z

Closing this as it's been replaced by #6574

kenjis added enhancement PRs that improve existing functionalities database Issues or pull requests that affect the database layer labels Aug 2, 2022

lonnieezell changed the base branch from develop to 4.3 August 2, 2022 21:52

lonnieezell changed the base branch from 4.3 to develop August 2, 2022 21:53

lonnieezell changed the base branch from develop to 4.3 August 3, 2022 03:59

kenjis mentioned this pull request Aug 11, 2022

feat: [Forge] set foreign key name manually #6370

Closed

5 tasks

kenjis and others added 3 commits August 21, 2022 11:23

docs: add explanation

515152b

Co-authored-by: MGatner <mgatner@icloud.com>

docs: remove @todo

a12b231

GET/POST data and the Validation Errors are used together when a validation error occurs. Therefore, it is not bad that withInput() also saves the validation errors.

Adds a when() method to DB Basebuilder.

0314614

lonnieezell force-pushed the db-when branch from 32c13fe to 0314614 Compare August 21, 2022 04:28

lonnieezell added 2 commits August 20, 2022 23:30

Add breaking change text back into 4.2.2 changelog that was accidenta…

7c81e3e

…lly removed

code style fix run

ec79d03

kenjis added the 4.3 label Aug 21, 2022

kenjis added 2 commits August 21, 2022 16:28

fix: command usages

01de988

Merge pull request #6399 from kenjis/fix-ComposerJsonTest

b064a47

chore: update framework/composer json suggest

kenjis reviewed Aug 21, 2022

View reviewed changes

MGatner and others added 4 commits August 21, 2022 06:38

Merge pull request #6398 from naente/develop

1fc65c2

test: update test

ec98fc9

Merge pull request #6402 from kenjis/fix-command-usage

aed7114

fix: command usages

Exclude non-monolithic files from CS

e48296e

kenjis and others added 18 commits September 4, 2022 22:05

fix: TypeError when the value is not int or string

f768d16

Add inline_constructor_arguments option to class_definition

7c13249

Merge pull request #6486 from paulbalandan/class-definition

836a5aa

Add `inline_constructor_arguments` option to `class_definition`

Enable no_trailing_comma_in_singleline

7a32c6d

Enable single_line_comment_spacing

2a0c62f

Remove commented-out code

5a182de

Merge pull request #6492 from kenjis/fix-validation-greater_than_equa…

3be80cb

…l_to fix: Strict Validation Rules greater_than/less_than

Merge pull request #6482 from paulbalandan/no-trailing-comma-in-singl…

780f2e0

…e-line Enable `no_trailing_comma_in_singleline`

Merge pull request #6484 from paulbalandan/single_line_comment_spacing

a5154bf

Enable `single_line_comment_spacing`

Prep for 4.2.6 release

4fa83f7

Merge pull request #6494 from codeigniter4/release-4.2.6

d1a9d04

Prep for 4.2.6 release

Merge pull request #6495 from codeigniter4/develop

265ed2f

4.2.6 Ready code

Merge branch 'develop' into 4.3

c9eb3d5

style: composer cs-fix

b2d5f79

Merge pull request #6501 from kenjis/fix-cs

b411094

[4.3] update coding style

Adds a when() method to DB Basebuilder.

042fd2e

Add breaking change text back into 4.2.2 changelog that was accidenta…

b001465

…lly removed

code style fix run

47f06d6

kenjis reviewed Sep 6, 2022

View reviewed changes

Comment thread tests/system/Database/Builder/WhenTest.php Outdated

lonnieezell and others added 3 commits September 5, 2022 23:14

Addressing review comments

4a62537

Merge branch 'db-when' of github.com:codeigniter4/CodeIgniter4 into d…

be62d6a

…b-when

Update tests/system/Database/Builder/WhenTest.php

9c5b254

Co-authored-by: kenjis <kenji.uui@gmail.com>

kenjis added the stale Pull requests with conflicts label Sep 10, 2022

lonnieezell mentioned this pull request Sep 23, 2022

When/WhenNot methods for db in a trait #6574

Merged

5 tasks

lonnieezell closed this Sep 23, 2022

paulbalandan deleted the db-when branch October 30, 2022 14:11

Conversation

lonnieezell commented Aug 2, 2022 • edited by kenjis Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kenjis commented Aug 2, 2022

Uh oh!

kenjis commented Aug 3, 2022

Uh oh!

datamweb commented Aug 3, 2022

Uh oh!

kenjis commented Aug 3, 2022

Uh oh!

datamweb commented Aug 3, 2022

Uh oh!

kenjis commented Aug 12, 2022

Uh oh!

lonnieezell commented Aug 21, 2022

Uh oh!

kenjis Aug 21, 2022

Choose a reason for hiding this comment

Uh oh!

lonnieezell Sep 6, 2022

Choose a reason for hiding this comment

Uh oh!

kenjis Aug 21, 2022

Choose a reason for hiding this comment

Uh oh!

lonnieezell Sep 6, 2022

Choose a reason for hiding this comment

Uh oh!

kenjis Aug 21, 2022

Choose a reason for hiding this comment

Uh oh!

lonnieezell Sep 6, 2022

Choose a reason for hiding this comment

Uh oh!

kenjis commented Aug 21, 2022

Uh oh!

Uh oh!

lonnieezell commented Sep 6, 2022

Uh oh!

iRedds commented Sep 15, 2022

Uh oh!

lonnieezell commented Sep 23, 2022 • edited by kenjis Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lonnieezell commented Sep 23, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

lonnieezell commented Aug 2, 2022 •

edited by kenjis

Loading

lonnieezell commented Sep 23, 2022 •

edited by kenjis

Loading