Skip to content

docs: improve PR workflow#6372

Merged
kenjis merged 4 commits intocodeigniter4:developfrom
kenjis:improve-pr-workflow
Aug 13, 2022
Merged

docs: improve PR workflow#6372
kenjis merged 4 commits intocodeigniter4:developfrom
kenjis:improve-pr-workflow

Conversation

@kenjis
Copy link
Copy Markdown
Member

@kenjis kenjis commented Aug 12, 2022

Description

  • add "If you sent to the wrong branch"
  • add optional step to back up the PR branch

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • [] Conforms to style guide

Copy link
Copy Markdown
Contributor

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Copy link
Copy Markdown
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! Seems a frequent need. One suggestion, take it or leave it.

Comment thread contributing/workflow.md
@kenjis kenjis merged commit 556178d into codeigniter4:develop Aug 13, 2022
@kenjis kenjis deleted the improve-pr-workflow branch August 13, 2022 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants